-
Notifications
You must be signed in to change notification settings - Fork 5.4k
refactor: upgrade Storybook 8.6 to 10.3 with webpack #17900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
57031b8
refactor(storybook): normalize @storybook/react/* wildcard imports to…
pettinarip 56df7d9
refactor(storybook): upgrade from Storybook 8.6 to 9.1
pettinarip 838d7d9
fix(storybook): update PhoneDecorator import missed by SB9 automigration
pettinarip b0e2cc0
refactor(storybook): convert next-intl.ts from require() to ESM
pettinarip f33d93c
refactor(storybook): upgrade from Storybook 9.1 to 10.3
pettinarip e8ab3a4
refactor(storybook): update third-party addons for SB10
pettinarip 6b1770d
docs: update storybook import path in applying-storybook.md
pettinarip c05abbe
fix(storybook): revert next-intl.ts to require() for webpack bundling
pettinarip 67cdeb6
fix(storybook): remove vite added by sb10 automigration
pettinarip 9ba9539
update pnpm lock
pettinarip f2162f8
fix(storybook): update tsconfig for SB10 module resolution
pettinarip 4147ab9
fix: replace deep imports incompatible with bundler module resolution
pettinarip 128acf0
fix: update storybook version ref in docs and fix import ordering in …
pettinarip 097a282
fix: move type alias below imports in compile.ts
pettinarip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still recognized/needed in SB10? Potential loose end, not a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems so https://storybook.js.org/docs/get-started/frameworks/nextjs/?renderer=react#react-server-components-rsc