fix: pin @docsearch/css to 3.9.0 to match @docsearch/react v3#17878
Merged
Conversation
PR #17818 added @docsearch/css@^4.6.0 as an explicit dependency, but @docsearch/react is still at v3.9.0 which expects @docsearch/css@3.9.0. The v4 CSS caused several regressions: purple search icon, constant spinner in modal, and broken hover/highlight styles.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
dependencies 📦
Merged
Member
|
Thanks @pettinarip, yeah would've been from #17818 🙏 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@docsearch/cssto3.9.0to match the version expected by@docsearch/react@3.9.0@docsearch/css@^4.6.0which resolved to v4, but the React component is v3 — the v4 CSS caused style regressionsWhat was broken
text-primary, while v3 sets body color on.DocSearch-Search-Icon.DocSearch-LoadingIndicatorby default (display: flex), while v3 hides it unless.DocSearch-Container--Stalledis presentReported in #17874 (comment): #17874 (comment)
Test plan