refactor: upgrade prism-react-renderer from v1 to v2#17876
Merged
Conversation
Migrate Codeblock component to prism-react-renderer v2 API: - Replace default import + defaultProps with named exports - Import Prism from main package instead of subpath - Add required `plain` property to custom light/dark themes - Remove deprecated `key` param from getLineProps/getTokenProps - Fix lint issues: type `child` param, use bare catch clause
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
requested changes
Mar 27, 2026
Member
wackerow
left a comment
There was a problem hiding this comment.
@pettinarip nice! Overall looks good, all above "tests" look good, but just noting a couple things:
(JavaScript example)
PR:


- We're getting an extra blank line at the ends
- Copy button has lost our primary color
- Contrast has dropped a bit with this new color scheme
- Dark mode
web3.eth.getBlockNumber().then(console.log)doesn't really show any distinction between tokens
I would consider first two as blockers. The others seem fine, just noting the difference.
Separately, this has made me realize that there are a lot of code fences that have their own empty lines (unrelated to above bug) at the end that we could easily regex and clean up (out of scope here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Upgrades
prism-react-rendererfrom v1 (1.1.0) to v2 (2.4.1). Deferred from #17781.Highlight,Prism,themes) — dropdefaultPropsthemes.duotoneLight/themes.duotoneDarkuseTheme()directly instead ofuseColorModeValue(which defaulted to dark on first render)backgroundColoron both themes sobg-background-highlightcontrols the backgroundoverflow-scroll→overflow-auto(scrollbars only when needed)getValidChildrenForCodeblockparam, use barecatchTest plan