Refactor all fetchers to use fetchRetry#17850
Merged
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
Mar 26, 2026
Comment on lines
+20
to
+22
| /** Sleep for specified milliseconds. */ | ||
| export const sleep = (ms: number) => | ||
| new Promise((resolve) => setTimeout(resolve, ms)) |
Member
There was a problem hiding this comment.
Could consider leaving this back in the fetch util, unless it needs to be inside data-layer dir.. not a blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
fetch()withfetchRetry()across all 26 data-layer fetchers for automatic retry on transient HTTP errors (408, 409, 429, 500-599)retry()wrapper usage infetchGitHubandfetchNpmJs, consolidating retry logic into the sharedfetchRetryutilitysrc/lib/utils/fetch.ts(old retry/sleep utilities)fetchRetryfor custom retry strategies (e.g."headers"strategy for APIs withRetry-After)Details
fetchRetrywraps Trigger.dev'sretry.fetchwith exponential backoff (3 attempts) on 408, 409, 429, and 500-599fetchGitHubContributorsandfetchGitHistory(GitHub uses 403, not 429)sleeputility exported fromfetchRetry.tsfor shared useTest plan
npx tsc --noEmit)