Skip to content

feat: hide contributors if edit button hidden#17797

Merged
pettinarip merged 1 commit into
devfrom
hide-contributes
Mar 24, 2026
Merged

feat: hide contributors if edit button hidden#17797
pettinarip merged 1 commit into
devfrom
hide-contributes

Conversation

@wackerow
Copy link
Copy Markdown
Member

Description

  • Hides FileContributors component on pages marked with hideEditButton

Used on only a few pages, the hideEditButton flag is available for certain more-protected pages which intentionally limit community contributions for editing. In these cases, showing the file contributors component feels less appropriate.

Current affected pages

  • /community/events/organizing/
  • /cookie-policy/
  • /foundation/
  • /privacy-policy/
  • /terms-of-use/
  • /whitepaper/

cc: @konopkja

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 18, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit fd551cf
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69bad59999d1cd0008d6affd
😎 Deploy Preview https://deploy-preview-17797.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 59 (🟢 up 3 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wackerow
Copy link
Copy Markdown
Member Author

Side note, the current usage appears to be exclusively via the "static" layout. I've applied to patch to the three layouts that contained this component, but raises the question if it's worth even having hideEditButton as a front matter prop for any template other than static (i.e., docs or tutorials). I don't see a case when we'd want to hide that button for anything using those layouts, so maybe worth just removing.

@pettinarip pettinarip merged commit d329f86 into dev Mar 24, 2026
9 checks passed
@pettinarip pettinarip deleted the hide-contributes branch March 24, 2026 13:32
@pettinarip pettinarip mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants