fix: withdrawal credentials widget#17776
Merged
Merged
Conversation
- deprecates usage of beaconcha.in fetch - fixes broken fetch - replace with link to beaconcha.in validator details page for inputted validator index - update copy for guidance
Co-authored-by: Gemini <noreply@google.com>
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
1 task
pettinarip
approved these changes
Mar 27, 2026
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
looks good, left one comment about a11y
| <ButtonLink | ||
| href={testnetHref} | ||
| variant="outline" | ||
| className={disabledClass} |
Member
There was a problem hiding this comment.
this one is tricky for screen readers and tabbing because the link exists and the readers will announce them.
would recommend either conditionally render the href (pass href={inputValue ? mainnetHref : undefined}) or add aria-disabled="true" and tabIndex={-1} alongside the CSS classes.
Keep beaconcha.in references in current-p (PR change). Take newer Crowdin translations for other keys. Drop unused error/upgraded/not-upgraded keys. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Add aria-disabled and tabIndex={-1} when input is
empty so screen readers announce disabled state and
links are removed from tab order.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Member
Author
|
Cerberus, block Pum482930 |
|
|
myelinated-wackerow
force-pushed
the
withdrawal-creds-key
branch
from
35c93cd to
73441a4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WithdrawalCredentials; replace with direct link tobeaconcha.in/validator/<index>#deposits(mainnet) andhoodi.beaconcha.in/validator/<index>#deposits(testnet)Related Issue