fix: restore "show-more" translation key removed by #17662#17774
Merged
Conversation
PR #17662 incorrectly identified "show-more" as unused because TruncatedText.tsx constructed the key dynamically via template literal. This restores the key across all 25 locales and switches to explicit key references so static analysis tools can detect usage.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"show-more"translation key tocommon.jsonacross all 25 locales — it was incorrectly removed by perf: remove unused keys from common.json namespace #17662TruncatedText.tsxwith explicit key references so static analysis tools can detect usageWhat happened
PR #17662 used automated scanning to find unused keys in
common.json. It missed thatTruncatedText.tsxuses"show-more"because the key was constructed dynamically:Test plan
TruncatedText"Show more" / "Show less" toggle works correctly