perf: convert footer to server component#17650
Merged
Merged
Conversation
Extract interactive "go to top" button into tiny client component, convert main Footer to async server component using getTranslations. Reduces client JS hydration by ~95%.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
Feb 25, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
🎉
Lgtm, only tiny suggestion would be to consider just using children prop instead of label but just semantic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoToTopButton.tsx)getTranslationsfromnext-intl/serverinstead of client-sideuseTranslationhookWhy
The Footer was marked as
"use client"only because:useTranslationhook (client-side)onClickhandler for the "go to top" buttonThis meant ~400 lines of static content (links, text) were being hydrated unnecessarily.
Changes
src/components/Footer/index.tsxgetTranslationssrc/components/Footer/GoToTopButton.tsxsrc/components/Footer.tsxTest plan