fix(ab-test): extract client IP from x-forwarded-for header#17612
Merged
Conversation
The x-forwarded-for header contains a comma-separated list of IPs: "client_ip, proxy1, proxy2, cdn_edge". With Cloudflare in front, the proxy IPs change between requests causing different fingerprints and non-deterministic variant assignment. Fix: Extract only the first IP (the actual client) for stable fingerprinting.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes non-deterministic A/B test variant assignment caused by the Cloudflare proxy layer.
Problem: The
x-forwarded-forheader contains a comma-separated list of IPs:"client_ip, proxy1, proxy2, cdn_edge". With Cloudflare in front, the proxy IPs change between requests (different edge nodes handle different requests), causing different fingerprints and non-deterministic variant assignment for the same user.Fix: Extract only the first IP (the actual client IP) for stable fingerprinting.
Test plan