Deploy v10.24.0

.claude/commands/review-translations.md

@@ -1,7 +1,7 @@
 ---
 description: Review translation imports for quality issues (runs after sanitizer)
-allowed-tools: Bash, Read, Glob, Grep, Task, AskUserQuestion
-argument-hint: [--pr=NUMBER (auto)] [--scope=pr|full (pr)] [--language=CODE] [--model=opus|sonnet|haiku (opus)]
+allowed-tools: Bash, Read, Glob, Grep, Task, Edit, AskUserQuestion
+argument-hint: [--pr=NUMBER (auto)] [--scope=pr|full (pr)] [--language=CODE] [--model=opus|sonnet|haiku (opus)] [--fix]
 ---
 
 # Translation Review Command
@@ -44,6 +44,7 @@ Reviews all files for a language when no PR context is available.
 | `--scope=pr\|full` | `pr` = only PR changed files, `full` = all files for languages | `pr` |
 | `--language=CODES` | Filter to specific language(s), comma-separated | all languages in PR |
 | `--model=MODEL` | Model for analysis: `opus` (deep), `sonnet` (balanced), `haiku` (fast) | `opus` |
+| `--fix` | Automatically apply fixes for critical issues after review | disabled |
 
 ## Phase 0: Determine Mode and Scope
 

.github/workflows/claude-review-translations.yml

@@ -1,6 +1,38 @@
 name: Claude Translation Review
 
 on:
+  workflow_dispatch:
+    inputs:
+      pr_number:
+        description: "PR number to review"
+        required: true
+        type: number
+      language:
+        description: "Language code(s) to review (comma-separated, e.g. 'hi' or 'hi,bn')"
+        required: false
+        type: string
+      scope:
+        description: "Review scope"
+        required: false
+        default: "pr"
+        type: choice
+        options:
+          - pr
+          - full
+      model:
+        description: "Claude model for analysis"
+        required: false
+        default: "opus"
+        type: choice
+        options:
+          - opus
+          - sonnet
+          - haiku
+      fix:
+        description: "Automatically fix critical translation issues"
+        required: false
+        default: false
+        type: boolean
   issue_comment:
     types: [created]
   pull_request_review_comment:
@@ -12,27 +44,29 @@ jobs:
   review-translations:
     # Runs when:
     # 1. Comment contains @claude /review-translations (from authorized user), OR
-    # 2. PR is opened with title starting with "i18n:" (automatic)
+    # 2. PR is opened with title starting with "i18n:" (automatic), OR
+    # 3. Manually dispatched from Actions tab with a PR number
     if: |
+      github.event_name == 'workflow_dispatch' ||
       (
         github.event_name == 'issue_comment' &&
         contains(github.event.comment.body, '@claude') &&
         contains(github.event.comment.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.comment.user.login) &&
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.comment.user.login) &&
         github.event.issue.pull_request
       ) ||
       (
         github.event_name == 'pull_request_review_comment' &&
         contains(github.event.comment.body, '@claude') &&
         contains(github.event.comment.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.comment.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.comment.user.login)
       ) ||
       (
         github.event_name == 'pull_request' &&
         startsWith(github.event.pull_request.title, 'i18n:') &&
         startsWith(github.event.pull_request.head.ref, 'i18n/') &&
         github.event.pull_request.head.repo.full_name == github.repository &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.pull_request.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.pull_request.user.login)
       )
     runs-on: ubuntu-latest
     permissions:
@@ -49,26 +83,68 @@ jobs:
 
       - name: Get PR number
         id: pr
+        env:
+          # All values moved to env block to prevent shell injection
+          EVENT_NAME: ${{ github.event_name }}
+          INPUT_PR_NUMBER: ${{ github.event.inputs.pr_number }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+          ISSUE_NUMBER: ${{ github.event.issue.number }}
         run: |
-          if [[ "${{ github.event_name }}" == "pull_request" ]]; then
-            echo "number=${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT
+          if [[ "$EVENT_NAME" == "workflow_dispatch" ]]; then
+            PR_NUM="$INPUT_PR_NUMBER"
+          elif [[ "$EVENT_NAME" == "pull_request" || "$EVENT_NAME" == "pull_request_review_comment" ]]; then
+            PR_NUM="$PR_NUMBER"
           else
-            echo "number=${{ github.event.issue.number }}" >> $GITHUB_OUTPUT
+            PR_NUM="$ISSUE_NUMBER"
           fi
 
+          # Validate PR number is numeric to prevent injection in downstream usage
+          if [[ ! "$PR_NUM" =~ ^[0-9]+$ ]]; then
+            echo "Error: PR number must be numeric, got: $PR_NUM"
+            exit 1
+          fi
+
+          echo "number=$PR_NUM" >> $GITHUB_OUTPUT
+
       - name: Extract flags from comment
         id: parse
+        env:
+          EVENT_NAME: ${{ github.event_name }}
+          INPUT_LANGUAGE: ${{ github.event.inputs.language }}
+          INPUT_SCOPE: ${{ github.event.inputs.scope }}
+          INPUT_MODEL: ${{ github.event.inputs.model }}
+          INPUT_FIX: ${{ github.event.inputs.fix }}
+          COMMENT_BODY: ${{ github.event.comment.body }}
         run: |
           # For automatic triggers (pull_request), use defaults
-          if [[ "${{ github.event_name }}" == "pull_request" ]]; then
+          if [[ "$EVENT_NAME" == "pull_request" ]]; then
             echo "language_flag=" >> $GITHUB_OUTPUT
             echo "scope_flag=" >> $GITHUB_OUTPUT
             echo "model=opus" >> $GITHUB_OUTPUT
+            echo "fix_flag=" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          COMMENT_BODY="${{ github.event.comment.body }}"
+          # For manual dispatch, read directly from inputs
+          if [[ "$EVENT_NAME" == "workflow_dispatch" ]]; then
+            if [[ -n "$INPUT_LANGUAGE" && "$INPUT_LANGUAGE" =~ ^[a-zA-Z,-]+$ ]]; then
+              echo "language_flag=--language=${INPUT_LANGUAGE}" >> $GITHUB_OUTPUT
+            else
+              echo "language_flag=" >> $GITHUB_OUTPUT
+            fi
+            # INPUT_SCOPE and INPUT_MODEL are choice types, safe values enforced by GitHub
+            echo "scope_flag=--scope=${INPUT_SCOPE}" >> $GITHUB_OUTPUT
+            echo "model=${INPUT_MODEL}" >> $GITHUB_OUTPUT
+            # Set fix_flag based on checkbox input
+            if [[ "$INPUT_FIX" == "true" ]]; then
+              echo "fix_flag=--fix" >> $GITHUB_OUTPUT
+            else
+              echo "fix_flag=" >> $GITHUB_OUTPUT
+            fi
+            exit 0
+          fi
 
+          # COMMENT_BODY is passed via env to prevent shell injection.
           # Extract --language flag if present
           if [[ "$COMMENT_BODY" =~ --language=([a-zA-Z,-]+) ]]; then
             echo "language_flag=--language=${BASH_REMATCH[1]}" >> $GITHUB_OUTPUT
@@ -90,29 +166,51 @@ jobs:
             echo "model=opus" >> $GITHUB_OUTPUT
           fi
 
+          # Extract --fix flag if present
+          if [[ "$COMMENT_BODY" =~ --fix ]]; then
+            echo "fix_flag=--fix" >> $GITHUB_OUTPUT
+          else
+            echo "fix_flag=" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Post acknowledgment
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PR_NUMBER: ${{ steps.pr.outputs.number }}
+          RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        run: |
+          gh pr comment "$PR_NUMBER" --body "$(cat <<EOF
+          :globe_with_meridians: **Translation review started.** [View progress]($RUN_URL)
+          EOF
+          )"
+
       - name: Run Claude Translation Review
         uses: anthropics/claude-code-action@v1
+        timeout-minutes: 120
         with:
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
-          timeout_minutes: "120"
-          claude_args: "--model ${{ steps.parse.outputs.model }}"
-          # Enable Task tool for parallel language review agents (read-only - no git write operations)
-          allowed_tools: "Task,Glob,Grep,LS,Read,Bash(git status:*),Bash(git diff:*),Bash(git log:*),Bash(git worktree:*),Bash(gh api:*),Bash(gh pr view:*)"
+          claude_args: |
+            --model ${{ steps.parse.outputs.model }}
+            --allowedTools "Task,Glob,Grep,LS,Read,Edit,WebFetch,Bash(git status:*),Bash(git diff:*),Bash(git log:*),Bash(git fetch:*),Bash(git worktree:*),Bash(git add:*),Bash(git commit:*),Bash(gh api:*),Bash(gh pr view:*),Bash(gh pr comment:*)"
           prompt: |
             Execute the /review-translations command for PR #${{ steps.pr.outputs.number }}.
 
-            Arguments: --pr=${{ steps.pr.outputs.number }} ${{ steps.parse.outputs.language_flag }} ${{ steps.parse.outputs.scope_flag }}
+            Arguments: --pr=${{ steps.pr.outputs.number }} ${{ steps.parse.outputs.language_flag }} ${{ steps.parse.outputs.scope_flag }} ${{ steps.parse.outputs.fix_flag }}
 
-            Follow the instructions in .claude/commands/review-translations.md exactly.
+            Follow the instructions in .claude/commands/review-translations.md for Phase 0 (scope detection), Phase 1 (parallel agents), and Phase 2 (collecting results).
 
             IMPORTANT workflow modifications for GitHub Actions context:
             1. Use parallel Task agents (ONE agent per language) as specified in the skill
-            2. After completing the review, post the quality scores and findings as a comment on this PR
-            3. Do NOT apply fixes automatically - just report the issues found
-            4. Do NOT prompt for user input - this is an automated workflow
-            5. At the end of your review comment, if there are critical issues, include this section:
-               ---
-               **To apply fixes**, reply with:
-               ```
-               @claude Fix the critical brand name translation issues listed above
-               ```
+            2. After collecting results in Phase 2, post the full review report as a PR comment using:
+               gh pr comment ${{ steps.pr.outputs.number }} --body "..."
+               Use a HEREDOC for the body to preserve formatting.
+            3. If the report is very long (>60000 chars), split it into multiple comments per language
+            4. Auto-fix behavior - check if --fix flag is present in Arguments above:
+               - If --fix flag IS present: After posting the review, automatically apply fixes for all critical issues found using the Edit tool (work in PR branch worktree as specified in skill). Then commit the changes.
+               - If --fix flag is NOT present: Do NOT apply fixes automatically - just report the issues found. At the end of your review comment, if there are critical issues, include:
+                 ---
+                 **To apply fixes**, reply with:
+                 ```
+                 @claude /review-translations --fix
+                 ```
+            5. Do NOT prompt for user input with AskUserQuestion - this is fully automated

.github/workflows/claude.yml

@@ -18,25 +18,25 @@ jobs:
         github.event_name == 'issue_comment' &&
         contains(github.event.comment.body, '@claude') &&
         !contains(github.event.comment.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.comment.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.comment.user.login)
       ) ||
       (
         github.event_name == 'pull_request_review_comment' &&
         contains(github.event.comment.body, '@claude') &&
         !contains(github.event.comment.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.comment.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.comment.user.login)
       ) ||
       (
         github.event_name == 'pull_request_review' &&
         contains(github.event.review.body, '@claude') &&
         !contains(github.event.review.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.review.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.review.user.login)
       ) ||
       (
         github.event_name == 'issues' &&
         contains(github.event.issue.body, '@claude') &&
         !contains(github.event.issue.body, '/review-translations') &&
-        contains('minimalsm,pettinarip,wackerow,nloureiro,konopkja', github.event.issue.user.login)
+        contains(fromJSON('["minimalsm","pettinarip","wackerow","nloureiro","konopkja"]'), github.event.issue.user.login)
       )
     runs-on: ubuntu-latest
     permissions:

app/[locale]/apps/[application]/page.tsx

@@ -146,6 +146,12 @@ const Page = async ({
           <div className="flex flex-col gap-10 px-4 md:px-10">
             <Breadcrumb>
               <BreadcrumbList>
+                <BreadcrumbItem>
+                  <BreadcrumbLink href="/">Ethereum.org</BreadcrumbLink>
+                </BreadcrumbItem>
+                <BreadcrumbSeparator className="me-[0.625rem] ms-[0.625rem] text-gray-400">
+                  /
+                </BreadcrumbSeparator>
                 <BreadcrumbItem>
                   <BreadcrumbLink href="/apps">ALL APPS</BreadcrumbLink>
                 </BreadcrumbItem>

app/[locale]/apps/categories/[catetgoryName]/page.tsx

@@ -126,6 +126,12 @@ const Page = async ({
             breadcrumbs={
               <Breadcrumb>
                 <BreadcrumbList>
+                  <BreadcrumbItem>
+                    <BreadcrumbLink href="/">Ethereum.org</BreadcrumbLink>
+                  </BreadcrumbItem>
+                  <BreadcrumbSeparator className="me-[0.625rem] ms-[0.625rem] text-gray-400">
+                    /
+                  </BreadcrumbSeparator>
                   <BreadcrumbItem>
                     <BreadcrumbLink href="/apps" className="uppercase">
                       {t("page-apps-all-apps")}

app/[locale]/bug-bounty/page.tsx

@@ -183,7 +183,7 @@ export default async function Page({ params }: { params: Promise<Params> }) {
     },
     {
       title: "Nimbus",
-      link: "https://our.status.im/tag/nimbus/",
+      link: "https://nimbus.team/",
       image: nimbus,
     },
     {

app/[locale]/developers/page.tsx

@@ -275,6 +275,7 @@ const DevelopersPage = async ({ params }: { params: PageParams }) => {
               <div>
                 <Link
                   href="https://docs.scaffoldeth.io/llms-full.txt"
+                  className="block"
                   customEventOptions={{
                     eventCategory: "mid_boxes",
                     eventAction: "click",
@@ -283,6 +284,17 @@ const DevelopersPage = async ({ params }: { params: PageParams }) => {
                 >
                   Scaffold-ETH 2 <code>llms-full.txt</code>
                 </Link>
+                <Link
+                  href="https://ethskills.com/"
+                  className="block"
+                  customEventOptions={{
+                    eventCategory: "mid_boxes",
+                    eventAction: "click",
+                    eventName: "ethskills",
+                  }}
+                >
+                  ethskills.com - {t("page-developers-ethskills-label")}
+                </Link>
               </div>
             </Card>