Skip to content

fix(analytics): ensure link click tracking works with ButtonLink #17595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wackerow merged 3 commits into from
Feb 19, 2026
Merged

fix(analytics): ensure link click tracking works with ButtonLink #17595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d583d
fix(analytics): ensure link click tracking works with ButtonLink
pettinarip Feb 19, 2026
35ec279
Merge remote-tracking branch 'origin/dev' into fix/matomo-link-tracking
pettinarip Feb 19, 2026
7dd28e0
fix(analytics): include destination URL in link click event name
pettinarip Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 20 additions & 40 deletions src/components/ui/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
isPartiallyActive = true,
activeClassName = "text-primary",
customEventOptions,
onClick,
...props
}: LinkProps,
ref
Expand Down Expand Up @@ -98,25 +99,29 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
href,
}

// Create click handler that tracks events and calls any passed onClick
const createClickHandler =
(eventName: string) => (e: React.MouseEvent<HTMLAnchorElement>) => {
trackCustomEvent(
customEventOptions ?? {
eventCategory: "Link",
eventAction: "Clicked",
eventName: `${eventName} - ${href}`,
}
)
onClick?.(e)
}

if (isExternal) {
const { className, ...rest } = commonProps

return (
<a
target="_blank"
rel="noopener noreferrer"
onClick={() =>
trackCustomEvent(
customEventOptions ?? {
eventCategory: `Link`,
eventAction: `Clicked`,
eventName: "Clicked on external link",
eventValue: href,
}
)
}
className={cn("relative", className)}
{...rest}
onClick={createClickHandler("Clicked on external link")}
className={cn("relative", className)}
>
{isMailto ? (
<span className="text-nowrap">
Expand All @@ -141,17 +146,8 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
<NextLink
target="_blank"
rel="noopener noreferrer"
onClick={() =>
trackCustomEvent(
customEventOptions ?? {
eventCategory: `Link`,
eventAction: `Clicked`,
eventName: "Clicked on internal PDF",
eventValue: href,
}
)
}
{...commonProps}
onClick={createClickHandler("Clicked on internal PDF")}
>
{children}
</NextLink>
Expand All @@ -165,18 +161,11 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
// as a same-page scroll rather than a route change)
return (
<I18nLink
{...commonProps}
onClick={(e) => {
e.stopPropagation()
trackCustomEvent(
customEventOptions ?? {
eventCategory: "Link",
eventAction: "Clicked",
eventName: "Clicked on hash link",
eventValue: href,
}
)
createClickHandler("Clicked on hash link")(e)
}}
{...commonProps}
>
{children}
</I18nLink>
Expand All @@ -185,17 +174,8 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(

return (
<I18nLink
onClick={() =>
trackCustomEvent(
customEventOptions ?? {
eventCategory: `Link`,
eventAction: `Clicked`,
eventName: `Clicked on internal link`,
eventValue: href,
}
)
}
{...commonProps}
onClick={createClickHandler("Clicked on internal link")}
>
{children}
</I18nLink>
Expand Down
9 changes: 2 additions & 7 deletions src/components/ui/buttons/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,6 @@ const ButtonLink = React.forwardRef<HTMLAnchorElement, ButtonLinkProps>(
},
ref
) => {
const handleClick: React.MouseEventHandler<HTMLAnchorElement> = (
...args
) => {
customEventOptions && trackCustomEvent(customEventOptions)
onClick?.(...args)
}
return (
<Button
asChild
Expand All @@ -173,8 +167,9 @@ const ButtonLink = React.forwardRef<HTMLAnchorElement, ButtonLinkProps>(
className
)}
activeClassName=""
customEventOptions={customEventOptions}
onClick={onClick}
{...linkProps}
onClick={handleClick}
>
{children}
</BaseLink>
Expand Down