Skip to content

fix(sitemap): include dynamic route pages and remove stale entries#17567

Closed
minimalsm wants to merge 3 commits into
devfrom
seo/016-sitemap-dynamic-routes
Closed

fix(sitemap): include dynamic route pages and remove stale entries#17567
minimalsm wants to merge 3 commits into
devfrom
seo/016-sitemap-dynamic-routes

Conversation

@minimalsm
Copy link
Copy Markdown
Contributor

@minimalsm minimalsm commented Feb 15, 2026

Summary

  • Adds all /apps/* individual app pages to the sitemap (enumerated from data layer)
  • Adds all /apps/categories/* pages to the sitemap (from static category definitions)
  • Adds root homepage URL (https://ethereum.org/)
  • Filters out /developers/tutorials/ipfs-decentralized-ui/ (canonicalizes elsewhere)

Test plan

  • All /apps/* pages appear in /sitemap.xml
  • All /apps/categories/* pages appear in /sitemap.xml
  • Root homepage URL present
  • No ipfs-decentralized-ui entries
  • No duplicate entries

@minimalsm
fix(sitemap): include dynamic route pages and remove stale entries
f8bd758 
Adds pages from dynamic routes (app detail pages, app category pages)
to the sitemap. Removes entries for pages that canonicalize elsewhere.
Also includes the root homepage URL.
@minimalsm
fix(sitemap): also include developer tools category pages
f492d35 
Adds /developers/tools/[category] pages (education, sdks, contracts,
security, etc.) which were also excluded by the dynamic route filter.
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 15, 2026 •
edited
Loading

❌ Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 96b5dab
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69b0c0b8adac600008579648

@konopkja konopkja mentioned this pull request Mar 5, 2026
Closed
@myelinated-wackerow myelinated-wackerow mentioned this pull request Mar 11, 2026
Merged
@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Mar 11, 2026
@myelinated-wackerow
Copy link
Copy Markdown
Collaborator

myelinated-wackerow commented Mar 11, 2026

@minimalsm #17639 just landed, which covers the homepage and developer tools category pages from this PR. The /apps/* and /apps/categories/* sitemap additions here are still valuable though -- those routes are still missing from the sitemap.

I've merged dev into this branch and resolved the conflict. The Netlify build failed but it's unrelated to this PR. The branch builds successfully locally.

To get this across the line:

  • Remove the overlapping developer tools category additions (now handled by getDynamicIntlPagePaths() in translationRegistry.ts)
  • Remove lastModified, changeFrequency, and priority fields (Google ignores these; fix: sitemap issues and deduplicate #17639 stripped them)
  • Add hreflang alternates to match the pattern now in sitemap.ts

Let me know if you want a hand patching this up to get it over the line.

Reviewed by Claude / claude-opus-4-6

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Apr 10, 2026
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Apr 28, 2026

Production site checks these boxes in current state, less ipfs-decentralized-ui.

Seeing the canonical link for that page pointing to https://ethereum.org/developers/tutorials/ipfs-decentralized-ui/ so going to close this out, but if still an issue we can address separately.

@wackerow wackerow closed this Apr 28, 2026
@github-actions github-actions Bot added the abandoned This has been abandoned or will not be implemented label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

Assignees

No one assigned

Labels

abandoned This has been abandoned or will not be implemented Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minimalsm @myelinated-wackerow @wackerow