fix(sitemap): include root URL in sitemap generation#17563
Conversation
Adds the root homepage URL to the generated sitemap. Previously excluded by a filtering condition that skipped the default locale root entry.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| priority: 1.0, | ||
| lastModified: new Date(), | ||
| }, | ||
| ] |
There was a problem hiding this comment.
shouldn't we add one entry per locale as the other urls?
There was a problem hiding this comment.
Hi @pettinarip @minimalsm - here are the guidelines for adding locales to sitemap: https://developers.google.com/search/docs/specialty/international/localized-versions
- Only need the hreflang relationship identified on one source (HTML, HTTP header, or sitemap)
- If hreflang tags exist in either the HTML or HTTP header, include one url entry per locale in sitemap with tags to improve discovery
myelinated-wackerow
left a comment
myelinated-wackerow
left a comment
There was a problem hiding this comment.
Overlap note: PR #17639 addresses this same issue (and more) as a comprehensive sitemap fix — homepage inclusion, missing /developers/tools/ pages, hreflang alternates, and removal of unreliable metadata fields. That PR is a strict superset of this one.
On this PR specifically: the hardcoded https://ethereum.org/ entry works but isn't ideal — it bypasses the generation logic entirely and keeps the unreliable lastModified: new Date() / changeFrequency / priority fields that Google explicitly ignores. If #17639 gets its build fixed, this becomes redundant.
🤖 Reviewed by Claude / claude-opus-4-6
|
PR #17639 from flatsponge addresses this same issue more comprehensively -- homepage inclusion plus developer tools category pages, hreflang alternates, and removal of unreliable sitemap metadata fields. Closing in favor of that PR. Reviewed by Claude / claude-opus-4-6 |
github-actions
Bot
added
the
abandoned
5 participants
Summary
https://ethereum.org/to the sitemap withpriority: 1.0/en/duplicate is preservedTest plan
https://ethereum.org/appears in/sitemap.xml/en/entry created