Skip to content

refactor(ui): filter bar for /apps/*, /developers/apps/*#17181

Merged
wackerow merged 4 commits into
page-developer-appsfrom
refactor-filter-bar
Feb 3, 2026
Merged

refactor(ui): filter bar for /apps/*, /developers/apps/*#17181
wackerow merged 4 commits into
page-developer-appsfrom
refactor-filter-bar

Conversation

@wackerow
Copy link
Copy Markdown
Member

@wackerow wackerow commented Jan 27, 2026

Extends page-developer-apps branch

Summary

  • Create reusable FilterBar component with searchable combobox pattern (Command + Popover)
  • Migrate /apps section to use shared FilterBar
  • Migrate /developers/apps/[category] section to use shared FilterBar
  • Consolidate filter-related i18n strings to common namespace

Changes

New Components

  • src/components/FilterBar/index.tsx - Reusable filter component with Matomo tracking support
  • src/components/FilterBar/FilterBar.stories.tsx - Storybook stories
  • app/[locale]/developers/apps/_components/CategoryAppsGrid.tsx - Client component for category grid with filtering

Refactored

  • app/[locale]/apps/_components/AppsTable.tsx - Now uses shared FilterBar
  • app/[locale]/developers/apps/[category]/page.tsx - Simplified with extracted grid component

Removed

  • app/[locale]/developers/apps/_components/TagFilter.tsx - Replaced by FilterBar

i18n

  • Added filter-bar-* keys to src/intl/en/common.json
  • Keys to deprecate from page namespaces (follow-up): page-developers-apps-filter-*

Testing

  • FilterBar Storybook stories render correctly
  • /apps filtering works with category selection
  • /developers/apps/[category] filtering works with tag selection
  • Clear filter button resets selection
  • Count display shows filtered/total format when filter active

Compound Engineered 🤖 Generated with Claude
Code

wackerow and others added 3 commits January 27, 2026 13:55
- Add filter-bar-* i18n keys to common.json namespace
- Create FilterBar component with searchable combobox (Command + Popover)
- Add Storybook stories for component testing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace Select dropdown with reusable FilterBar

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create CategoryAppsGrid client component using shared FilterBar
- Move filtering state from URL params to client-side useState
- Delete TagFilter component (replaced by FilterBar)
- Simplify page.tsx by extracting grid logic to dedicated component

Co-Authored-By: Claude <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 27, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cda4d15
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69793165f8538e00089e368f
😎 Deploy Preview https://deploy-preview-17181.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 57 (🟢 up 1 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jan 27, 2026
Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice!

@wackerow wackerow merged commit ddbbdd9 into page-developer-apps Feb 3, 2026
7 checks passed
@wackerow wackerow deleted the refactor-filter-bar branch February 3, 2026 17:34
This was referenced Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants