refactor/feat(ui): ui/card and ui/tag component refactors#17109
Merged
Conversation
- fix: tailwind class mapping - deprecate: unused forceLightMode
- Consolidate CardDescription, CardHighlight and CardSubTitle into single CardParagraph component with cva variants - Update usage of components throughout repo - Add thumbnail variant for CardBanner - Add base variant for CardParagraph
Refactor existing usage of joining " · " to use standardized component
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
approved these changes
Jan 19, 2026
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@wackerow looks good. Left a few minor comments
| const listVariants = cva("", { | ||
| variants: { | ||
| variant: { | ||
| light: "text-sm text-body-medium", |
Member
There was a problem hiding this comment.
shouldn't this style be part of the base style? otherwise, shouldn't we add a defaultVariants?
Member
Author
There was a problem hiding this comment.
We use both, and felt cleaner to leave the base case as unstyled, so we didn't default to text-sm and text-body-medium to then have to override it to remove it. This leaves default case without additional styling, with option to add the "light" variant
- Fix component display name - Move size mapping constant to constants file - Remove redundant className usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
In preparation for new /developers/apps pages