Skip to content

refactor: simplify events data layer and document patterns#17088

Merged
wackerow merged 5 commits into
events-revampfrom
refactor/simplify-events-data-layer
Jan 15, 2026
Merged

refactor: simplify events data layer and document patterns#17088
wackerow merged 5 commits into
events-revampfrom
refactor/simplify-events-data-layer

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented Jan 15, 2026

Summary

  • Remove unused legacy mock data (src/data/mocks/events.json) and reduce events mock size
  • Simplify getEventsData getter to follow the pure passthrough pattern (no transformations in getters)
  • Expose getEventsData via @/lib/data with caching (CACHE_REVALIDATE_DAY)
  • Update all imports across pages to use the cached version from @/lib/data
  • Document key data-layer rules in docs.md
  • Add Claude Code skill to enforce data-layer patterns

Test plan

  • Verify events pages still load correctly
  • Check that caching works as expected

Document the patterns established in this refactor:
- Data-layer getters must be pure passthrough (no transformations)
- Expose via lib/data for caching/revalidation

Add Claude Code skill to enforce these patterns when working
with src/data-layer/ or src/lib/data/ files.
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 15, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ec8bab0
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6968ef0e39875600083c921e
😎 Deploy Preview https://deploy-preview-17088.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 56 (🟢 up 2 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jan 15, 2026
@pettinarip pettinarip changed the base branch from dev to events-revamp January 15, 2026 13:44
@pettinarip pettinarip mentioned this pull request Jan 15, 2026
@wackerow wackerow removed the translation 🌍 This is related to our Translation Program label Jan 15, 2026
@wackerow wackerow merged commit e468c9f into events-revamp Jan 15, 2026
7 checks passed
@wackerow wackerow deleted the refactor/simplify-events-data-layer branch January 15, 2026 15:57
@wackerow wackerow mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants