Skip to content

fix: remove unnecessary forwardRef from AlertEmoji#17049

Merged
pettinarip merged 1 commit into
devfrom
fix/alert-emoji-forward-ref
Jan 12, 2026
Merged

fix: remove unnecessary forwardRef from AlertEmoji#17049
pettinarip merged 1 commit into
devfrom
fix/alert-emoji-forward-ref

Conversation

@wackerow
Copy link
Copy Markdown
Member

@wackerow wackerow commented Jan 10, 2026

Summary

  • Remove forwardRef wrapper from AlertEmoji component
  • The underlying Emoji component doesn't accept a ref, so wrapping in forwardRef was causing React warnings about unused ref parameters

Test plan

  • Verify React warning no longer appears in console when AlertEmoji is rendered
  • Ensure passing build and other instances of AlertEmoji are unaffected

🤖 Generated with Claude Code

Related issue

Fixes:

Warning: forwardRef render functions accept exactly two parameters: props and ref. Did you forget to use the ref parameter?

The Emoji component does not accept a ref, so wrapping AlertEmoji in
forwardRef was causing React warnings about unused ref parameters.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 10, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2092e22
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6961ae39616595000899b52b
😎 Deploy Preview https://deploy-preview-17049.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 57 (🟢 up 5 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (🟢 up 1 from production)
SEO: 100 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip merged commit 535f427 into dev Jan 12, 2026
7 checks passed
@pettinarip pettinarip deleted the fix/alert-emoji-forward-ref branch January 12, 2026 12:32
@wackerow wackerow mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants