Implement apps of the week feature#16584
Merged
Merged
Conversation
corwintines
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
requested changes
Oct 27, 2025
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
@corwintines Guessing the parseAppsOfTheWeek function may not be pulling in what we need? didn't look too deep, but doesn't appear to be rendering
| matomoCategory="apps-of-the-week" | ||
| /> | ||
| <div className="flex justify-center"> | ||
| <ButtonLink href="/apps">Browse apps ></ButtonLink> |
Member
There was a problem hiding this comment.
Suggested change
| <ButtonLink href="/apps">Browse apps ></ButtonLink> | |
| <ButtonLink href="/apps"> | |
| Browse apps <ChevronNext /> | |
| </ButtonLink> |
Comment on lines
+528
to
+531
| <AppsHighlight | ||
| apps={appsOfTheWeek} | ||
| matomoCategory="apps-of-the-week" | ||
| /> |
Member
There was a problem hiding this comment.
Hm... looks like this isn't rendering?
Member
There was a problem hiding this comment.
Ah, never mind, I see this was just a mock data issue, looks good locally
Member
Author
There was a problem hiding this comment.
Ah woops I will get mock data updated here
wackerow
approved these changes
Oct 28, 2025
This was referenced Nov 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the Apps of the Week feature on the homepage