Skip to content

Upgrade GitHub Action to pnpm/action-setup@v4#16468

Merged
wackerow merged 9 commits into
ethereum:devfrom
MamunC0der:dev
Oct 9, 2025
Merged

Upgrade GitHub Action to pnpm/action-setup@v4#16468
wackerow merged 9 commits into
ethereum:devfrom
MamunC0der:dev

Conversation

@MamunC0der
Copy link
Copy Markdown
Contributor

Version v4 includes enhanced caching, faster setup times, and support for newer PNPM versions.
Release notes: https://github.com/pnpm/action-setup/releases/tag/v4.2.0

Change:
uses: pnpm/action-setup@v2 → uses: pnpm/action-setup@v4

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Oct 8, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 8, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e5c0f52
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68e6a32f182e6a0008ea5404
😎 Deploy Preview https://deploy-preview-16468--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 4 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 8, 2025

@claude please review

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Oct 8, 2025

Claude finished @wackerow's task —— View job


PR Review: Upgrade GitHub Action to pnpm/action-setup@v4

Todo List:

  • Read and analyze all changed workflow files
  • Verify consistency of version upgrades
  • Check for any potential issues or missing configurations
  • Provide comprehensive review feedback

Review Summary

LGTM - This upgrade looks good!

What I Found

Positive Changes:

  • Consistent upgrade across all 9 workflow files: All instances of pnpm/action-setup@v2 are being upgraded to @v4
  • Good timing: v4 includes enhanced caching, faster setup times, and better support for newer PNPM versions
  • No breaking changes expected: The upgrade from v2 to v4 should be backward compatible with existing configurations

Files Reviewed:

  • .github/workflows/chromatic.yml - ✅ Updated (line 31)
  • .github/workflows/crowdin-ci.yml - ✅ Updated (line 22)
  • .github/workflows/generate-review-report.yml - ✅ Updated (line 14)
  • .github/workflows/get-crowdin-contributors.yml - ✅ Updated (line 16)
  • .github/workflows/get-leaderboard-reports.yml - ✅ Updated (line 16)
  • .github/workflows/get-translation-progress.yml - ✅ Updated (line 16)
  • .github/workflows/import-community-events.yml - ✅ Updated (line 16)
  • .github/workflows/playwright.yml - ✅ Updated (lines 17 & 60)
  • .github/workflows/update-chains.yml - ✅ Updated (line 17)

Analysis:

  1. Version consistency: All upgrades are from @v2@v4 (no mixed versions)
  2. Configuration preservation: All existing version: 10 specifications are maintained
  3. No additional configuration needed: v4 is backward compatible with existing setup
  4. Performance benefits: According to the v4 release notes, this brings enhanced caching and faster setup times

No Issues Found:

  • All version references are correctly updated
  • No missing configurations or syntax errors
  • Consistent formatting maintained across all files

Recommendation:

Approve and merge - This is a straightforward maintenance upgrade that will improve CI performance without any risk.

Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MamunC0der!

@wackerow wackerow merged commit 0bd718f into ethereum:dev Oct 9, 2025
7 checks passed
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 9, 2025

@all-contributors please add @MamunC0der for maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

@MamunC0der already contributed before to maintenance

This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants