Skip to content

Upgrade GitHub Action to setup-node@v5#16457

Merged
wackerow merged 9 commits into
ethereum:devfrom
MamunC0der:dev
Oct 8, 2025
Merged

Upgrade GitHub Action to setup-node@v5#16457
wackerow merged 9 commits into
ethereum:devfrom
MamunC0der:dev

Conversation

@MamunC0der
Copy link
Copy Markdown
Contributor

Version v5 introduces enhanced caching, improved environment detection, and better compatibility with Node.js 20+.
Release notes:https://github.com/actions/setup-node/releases/tag/v5.0.0)

Change:
uses: actions/setup-node@v4 -> uses: actions/setup-node@v5

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 7, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9ff098b
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68e540434e15f90008bfe188
😎 Deploy Preview https://deploy-preview-16457--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 11 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Oct 7, 2025
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 7, 2025

@claude review PR please

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Oct 7, 2025

Claude finished @wackerow's task —— View job


PR Review: Upgrade GitHub Action to setup-node@v5

Review Checklist

  • Examine all 9 workflow files for consistency
  • Verify setup-node@v5 compatibility and benefits
  • Check for potential breaking changes
  • Provide comprehensive review feedback

Review Summary

Changes Look Good

Consistency: All 9 workflow files have been consistently updated from actions/setup-node@v4 to actions/setup-node@v5:

  • .github/workflows/chromatic.yml:35
  • .github/workflows/crowdin-ci.yml:27
  • .github/workflows/generate-review-report.yml:19
  • .github/workflows/get-crowdin-contributors.yml:21
  • .github/workflows/get-leaderboard-reports.yml:21
  • .github/workflows/get-translation-progress.yml:21
  • .github/workflows/import-community-events.yml:21
  • .github/workflows/playwright.yml:12 and .github/workflows/playwright.yml:56
  • .github/workflows/update-chains.yml:22

Configuration Compatibility: All workflows maintain their existing Node.js configurations (primarily Node 20, with one using Node 22.12.0 and one using lts/*), which are fully compatible with setup-node@v5.

🔍 Key Benefits of v5 Upgrade

  • Enhanced Caching: Improved caching mechanisms for better performance
  • Better Node.js 20+ Support: Enhanced compatibility with current Node.js versions (all workflows use Node 20+)
  • Improved Environment Detection: Better handling of different CI environments
  • Security Updates: Latest security patches and improvements

⚠️ Minor Observations

  1. Mixed Node Version Specification:

    • Most workflows use node-version: 20 (specific)
    • playwright.yml:14 uses node-version: lts/* (flexible)
    • playwright.yml:58 uses node-version: 22.12.0 (very specific)

    This is not a problem, just worth noting the different approaches.

  2. No Breaking Changes: setup-node@v5 maintains backward compatibility with all existing configuration options used in these workflows.

📋 Technical Verification

  • ✅ All cache: 'pnpm' configurations remain compatible
  • ✅ No workflow logic changes required
  • ✅ All Node.js versions specified are supported by v5
  • ✅ pnpm integration remains unchanged

Recommendation: APPROVE

This is a straightforward maintenance upgrade that follows best practices:

  • Consistent application across all workflows
  • No breaking changes
  • Clear performance and compatibility benefits
  • Well-documented in the PR description with release notes reference

The upgrade aligns well with the project's use of modern Node.js versions and should provide improved CI performance and reliability.


Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @MamunC0der!

@wackerow wackerow merged commit 12355bf into ethereum:dev Oct 8, 2025
7 checks passed
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 8, 2025

@all-contributors please add @MamunC0der for maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @MamunC0der! 🎉

This was referenced Oct 9, 2025
This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants