Skip to content

Update link ds-implementation.md#16442

Merged
wackerow merged 3 commits into
ethereum:devfrom
NikolaiKryshnev:patch-1
Oct 6, 2025
Merged

Update link ds-implementation.md#16442
wackerow merged 3 commits into
ethereum:devfrom
NikolaiKryshnev:patch-1

Conversation

@NikolaiKryshnev
Copy link
Copy Markdown
Contributor

Updated link in docs/ds-implementation.md to point to Chakra UI v2 components documentation.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b84a975
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68e400d4e40f28000852ed5e
😎 Deploy Preview https://deploy-preview-16442--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 6 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the documentation 📖 Change or add documentation label Oct 6, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for highlighting this @NikolaiKryshnev... We no longer use Chakra in this repo, so glad you spotted this, but we wouldn't want to continue linking to Chakra docs or referencing. We use the shadcn/ui approach now with all base ui components living inside src/components/ui. Mind updating to remove all references to Chakra, and referencing the shadcn approach instead?

@NikolaiKryshnev
Copy link
Copy Markdown
Contributor Author

@wackerow done

Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NikolaiKryshnev! As I look at the references issue further, that issue is fairly out-of-date at this point so this may need to be updated further as we move along, but in the meantime I'll pull this in since we should definitely not be defaulting to Chakra at this point. 🚀

@wackerow wackerow merged commit 3a95255 into ethereum:dev Oct 6, 2025
6 checks passed
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Oct 6, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 6, 2025

@all-contributors please add @NikolaiKryshnev for maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @NikolaiKryshnev! 🎉

This was referenced Oct 9, 2025
This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📖 Change or add documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants