Skip to content

intl: add translations for eth-vs-btc common strings#16344

Merged
corwintines merged 1 commit into
devfrom
intl-btc-vs-eth
Sep 30, 2025
Merged

intl: add translations for eth-vs-btc common strings#16344
corwintines merged 1 commit into
devfrom
intl-btc-vs-eth

Conversation

@wackerow
Copy link
Copy Markdown
Member

Description

  • Adds translations for /ethereum-vs-bitcoin/ common.json strings (nav menu)
  • Translations via Gemini 2.5 Pro

Note: Strings can be sorted in a separate PR to keep this diff clean

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 23, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 379a4f5
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68d32ff795601a0008fcc88c
😎 Deploy Preview https://deploy-preview-16344--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 94 (🔴 down 1 from production)
Best Practices: 91 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: 59 (🟢 up 1 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 23, 2025
Copy link
Copy Markdown
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude review this PR, tell me if any mistakes in translation

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Sep 24, 2025

Claude finished @wackerow's task —— View job


Translation Review Complete

I've reviewed the translations for the eth-vs-btc common strings across multiple languages. Here are my findings:

Todo List

  • Read English source strings to understand context
  • Sample multiple language files for translation quality
  • Check for common translation issues and inconsistencies
  • Provide detailed review feedback

Review Findings

Source strings:

  • "ethereum-vs-bitcoin": "Ethereum vs Bitcoin"
  • "nav-ethereum-vs-bitcoin-description": "Understand the differences between Ethereum and Bitcoin"

Overall Assessment: Translations Look Good

I sampled 15+ languages across different language families and scripts. The translations are generally accurate and appropriate.

Positive Findings:

  1. Proper Brand Name Handling: All languages correctly preserve "Ethereum" and "Bitcoin" as proper nouns without translation

  2. Appropriate VS Formatting: Most languages use culturally appropriate comparison formats:

    • Romance languages: "vs." or "vs"
    • Asian languages: "vs." or native comparison words
    • Arabic: "مقابل" (muqābil = "versus/against")
    • Korean: "대" (dae = "versus")
  3. Accurate Descriptions: The description translations correctly convey "understand the differences between" concept across all languages

  4. Cultural Adaptation: Languages adapted the phrasing appropriately:

    • Turkish: "Ethereum ve Bitcoin Karşılaştırması" (adds "Comparison")
    • Vietnamese: "Ethereum và Bitcoin" (uses "and" instead of "vs")

Languages Reviewed:

  • European: Spanish, French, German, Italian, Portuguese, Turkish, Russian
  • Asian: Japanese, Chinese, Korean, Thai, Vietnamese, Hindi
  • Middle Eastern: Arabic
  • Multiple scripts: Latin, Cyrillic, Arabic, CJK, Devanagari, Thai

No Issues Found:

  • ❌ No mistranslations detected
  • ❌ No formatting inconsistencies
  • ❌ No encoding issues
  • ❌ No cultural inappropriateness
  • ❌ No technical terminology errors

Recommendation: ✅ APPROVE

The translations are high quality and ready for deployment. Gemini 2.5 Pro produced accurate, culturally appropriate translations that maintain technical accuracy while adapting to local linguistic conventions.

@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Sep 24, 2025
@corwintines corwintines merged commit 7e4af71 into dev Sep 30, 2025
8 checks passed
@corwintines corwintines deleted the intl-btc-vs-eth branch September 30, 2025 02:59
This was referenced Oct 9, 2025
This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program Update Crowdin PR introduces changes that need to be updated in Crowdin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants