update: Fusaka page, added non-core EIPs#16298
Conversation
…IPs, restructured links a little
nixorokish
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the updates @nixorokish, left some house-keeping suggestions then can get this pulled in.
| Specification: https://eips.ethereum.org/EIPS/eip-7594 | ||
|
|
||
| Resources: https://youtu.be/bONWd1x2TjQ?t=328 (dapplion on PeerDAS) |
There was a problem hiding this comment.
Also noting that @taxmeifyoucan also just put up content updates to this page linking out to this new PeerDAS page in #16296...
Not super picky where exactly we link to this, but would try to find one place for it. In that PR it was just placed as a raw URL next to this "Resources" line, and I had suggested moving it to it's own callout at the end of this section, which I see a similar approach below (just wouldn't duplicate links within a given page).
There was a problem hiding this comment.
thank you so much for the thorough review @wackerow !! moved the link to the bottom per your suggestion & also resolved the other comments
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Lookin good.. Couple small tiny nit-picks 🙏, then can get this in (alt text on the image diagram please)
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Looks good! Thanks @nixorokish
wackerow
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
3 participants
and restructured links a little
Description
Fusaka blog post coming soon, restructured some of the EIPs to match that so it's not confusing to audiences. ALSO PLEASE NOTE - there's an image I need attached (line 46), wasn't sure where in the file tree it needed to be, so right now it's a google drive link. Please lmk how to format correctly, thank you!
Related Issue
n/a