Add schema.org and JSONLD to pages#16186
Merged
Merged
Conversation
…dcrumb and creative work details
…metadata and breadcrumb navigation
…g metadata, breadcrumb navigation, and item list details
…etadata, breadcrumb navigation, and community resources details
…uding acknowledgements, contributors, and translatathon leaderboard with metadata and breadcrumb navigation
…adata, breadcrumb navigation, and resource details for tutorials, learning tools, local environment, and main developers page
…metadata, breadcrumb navigation, and publisher information
…ata, breadcrumb navigation, and publisher information
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
reviewed
Sep 5, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@corwintines maybe a late comment on this work but was wondering if we could abstract this code in a separate file to avoid adding too many things in each file and see if we can avoid some duplication
new-page/
├─ page.tsx
├─ page-jsonld.ts // exports an adapted PageJsonLD component to be used in page.tsx
components/
├─ PageJsonLD.tsx // generic component that prints the `script` tagsWe could set a pattern for all pages to look like this.
At the page level
import PageJsonLD from "./page-jsonld"
return (
<PageJsonLD {...frontmatter} />
...rest
)===
related issue to the mindset I had for this implementation.
github-actions
Bot
added
content 🖋️
pettinarip
reviewed
Sep 10, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@corwintines I've found two small issues. The rest looks great 👍🏼
pettinarip
reviewed
Sep 17, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@corwintines nice work. I'll patch the issues commented and bring this in.
Something we could improve later are pages with product listings, where we have invalid items
some of those pages are (not 100% sure if there are more):
pettinarip
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Can test schemas on https://search.google.com/test/rich-results
https://technicalseo.com/tools/google-serp-simulator/
More info on structured data: https://developers.google.com/search/docs/appearance/structured-data/search-gallery
More info on Schema.org: https://schema.org/
Info on JSON-LD: https://nextjs.org/docs/app/guides/json-ld