Clean up theme#16166
Merged
Merged
Conversation
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
reviewed
Sep 4, 2025
Comment on lines
+95
to
+113
| --card-gradient: linear-gradient( | ||
| 123deg, | ||
| rgba(255, 255, 255, 0.2) 58.99%, | ||
| rgba(174, 110, 203, 0.13) 104.04% | ||
| ); | ||
| --card-gradient-secondary: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.12) 0%, | ||
| rgba(159, 43, 212, 0.12) 102.78% | ||
| ); | ||
| --card-gradient-secondary-hover: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.2) 0%, | ||
| rgba(159, 43, 212, 0.2) 102.78% | ||
| ); | ||
| --ten-year-gradient: linear-gradient( | ||
| 100deg, | ||
| #f6c9ea 55.38%, | ||
| #c7a9f1 110.54% |
Member
There was a problem hiding this comment.
Per in-file comment:
/**
/* Gradients (radial, conic, or linear over 3 stops)
/* For linear-gradient up to 3 stops, use Tailwind classes
/* https://tailwindcss.com/docs/background-image#linear-gradients
*/Noting that these could be simple tailwind classes instead, though if we want to nit-pick on non-standard angles (123deg, 95deg, 100deg), that would have to wait for tailwind v4, where we could do bg-linear-123 as an example.
Otherwise we could standardize the angles with something like:
bg-gradient-to-br from-white/20 from-[59%] to-[rgb(174,110,203)]/[0.13] to-[104%] in situ
or
--card-gradient: @apply bg-gradient-to-br from-white/20 from-[59%] to-[rgb(174,110,203)]/[0.13] to-[104%];@pettinarip Not sure if you have a preference... not a huge deal, but given we're using tailwind I try to stick to classes where possible
wackerow
reviewed
Sep 15, 2025
Comment on lines
+95
to
114
| --card-gradient: linear-gradient( | ||
| 123deg, | ||
| rgba(255, 255, 255, 0.2) 58.99%, | ||
| rgba(174, 110, 203, 0.13) 104.04% | ||
| ); | ||
| --card-gradient-secondary: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.12) 0%, | ||
| rgba(159, 43, 212, 0.12) 102.78% | ||
| ); | ||
| --card-gradient-secondary-hover: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.2) 0%, | ||
| rgba(159, 43, 212, 0.2) 102.78% | ||
| ); | ||
| --ten-year-gradient: linear-gradient( | ||
| 100deg, | ||
| #f6c9ea 55.38%, | ||
| #c7a9f1 110.54% | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| --card-gradient: linear-gradient( | |
| 123deg, | |
| rgba(255, 255, 255, 0.2) 58.99%, | |
| rgba(174, 110, 203, 0.13) 104.04% | |
| ); | |
| --card-gradient-secondary: linear-gradient( | |
| 95deg, | |
| rgba(211, 145, 242, 0.12) 0%, | |
| rgba(159, 43, 212, 0.12) 102.78% | |
| ); | |
| --card-gradient-secondary-hover: linear-gradient( | |
| 95deg, | |
| rgba(211, 145, 242, 0.2) 0%, | |
| rgba(159, 43, 212, 0.2) 102.78% | |
| ); | |
| --ten-year-gradient: linear-gradient( | |
| 100deg, | |
| #f6c9ea 55.38%, | |
| #c7a9f1 110.54% | |
| ); | |
| --card-gradient: @apply bg-gradient-to-br from-white/20 from-[59%] to-[rgb(174,110,203)]/[0.13]; | |
| --card-gradient-secondary: @apply bg-gradient-to-r from-[rgb(211,145,242)]/[0.12] to-[rgb(159,43,212)]/[0.12]; | |
| --card-gradient-secondary-hover: @apply bg-gradient-to-r from-[rgb(211,145,242)]/20 to-[rgb(159,43,212)]/20; | |
| --ten-year-gradient: @apply bg-gradient-to-r from-[#f6c9ea] from-[55%] to-[#c7a9f1] to-[110%]; |
Member
There was a problem hiding this comment.
Hm actually, these aren't within a custom class, so that may not work right... but:
bg-card-gradientis only used in one place that I can find:app/[locale]/trillion-dollar-security/page.tsx
We could replace that usage withbg-gradient-to-br from-white/20 from-[59%] to-[rgb(174,110,203)]/[0.13]and remove this custom variable from the theme?bg-ten-year-gradientis also only used once, inapp/[locale]/10years/_components/TenYearHomeBanner.tsxattached toafter:
We could replace that usage withafter:bg-gradient-to-r after:from-[#f6c9ea] after:from-[55%] after:to-[#c7a9f1] after:to-[110%] dark:after:from-[#1e151b] dark:after:from-[55%] dark:after:to-black dark:after:to-[110%], and similarly remove from the theme.bg-card-gradient-secondary(4 uses) andbg-card-gradient-secondary-hover(2 uses)... could consider making custom classes for these two outside ofsemantic-tokens.css?
@pettinarip Just some thoughts on how to iterate on this, but for the sake of not over-complicating, going to accept and pull in what we have here.
wackerow
approved these changes
Sep 15, 2025
Comment on lines
+95
to
114
| --card-gradient: linear-gradient( | ||
| 123deg, | ||
| rgba(255, 255, 255, 0.2) 58.99%, | ||
| rgba(174, 110, 203, 0.13) 104.04% | ||
| ); | ||
| --card-gradient-secondary: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.12) 0%, | ||
| rgba(159, 43, 212, 0.12) 102.78% | ||
| ); | ||
| --card-gradient-secondary-hover: linear-gradient( | ||
| 95deg, | ||
| rgba(211, 145, 242, 0.2) 0%, | ||
| rgba(159, 43, 212, 0.2) 102.78% | ||
| ); | ||
| --ten-year-gradient: linear-gradient( | ||
| 100deg, | ||
| #f6c9ea 55.38%, | ||
| #c7a9f1 110.54% | ||
| ); |
Member
There was a problem hiding this comment.
Hm actually, these aren't within a custom class, so that may not work right... but:
bg-card-gradientis only used in one place that I can find:app/[locale]/trillion-dollar-security/page.tsx
We could replace that usage withbg-gradient-to-br from-white/20 from-[59%] to-[rgb(174,110,203)]/[0.13]and remove this custom variable from the theme?bg-ten-year-gradientis also only used once, inapp/[locale]/10years/_components/TenYearHomeBanner.tsxattached toafter:
We could replace that usage withafter:bg-gradient-to-r after:from-[#f6c9ea] after:from-[55%] after:to-[#c7a9f1] after:to-[110%] dark:after:from-[#1e151b] dark:after:from-[55%] dark:after:to-black dark:after:to-[110%], and similarly remove from the theme.bg-card-gradient-secondary(4 uses) andbg-card-gradient-secondary-hover(2 uses)... could consider making custom classes for these two outside ofsemantic-tokens.css?
@pettinarip Just some thoughts on how to iterate on this, but for the sake of not over-complicating, going to accept and pull in what we have here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused vars from theme and format
semantic-tokens.cssfile