Semrush SEO warnings#16110
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
config ⚙️
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Solid @corwintines 🔥 Thanks!
- Left a note about
LinkOverlaycomponent. - Comment on #16100 would apply here as well regarding
/translations/files: https://github.com/ethereum/ethereum-org-website/pull/16100/files#r2296743115
| eventName: "see_next", | ||
| }} | ||
| /> | ||
| <LinkOverlay asChild> |
There was a problem hiding this comment.
Correct me if I'm wrong, but from what I can tell this pattern applied to every usage of LinkOverlay in the codebase... we should update that component to automatically handle the asChild and BaseLink embedding
wackerow
added
the
Update Crowdin
|
cc: @lukassim |
|
Since this wasn't targeting |
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Lgtm! Left a few comments/questions but I think this is good to pull in
| locale, | ||
| slug: ["quizzes"], | ||
| title: t("common.quizzes-title"), | ||
| title: `${t("common.quizzes-title")} | ethereum.org`, |
There was a problem hiding this comment.
Fine with this for now, but we should tee up a separate task to apply this for all pages from within the getMetadata function itself... out-of-scope for here though
|
|
||
| <InfoBanner emoji=":wave:"> | ||
| Proof-of-work has now been deprecated. Ethereum no longer uses proof-of-work as part of its consensus mechanism. Instead, it uses proof-of-stake. Read more on <a href="/developers/docs/consensus-mechanisms/pos/">proof-of-stake</a> and <a href="/staking/">staking</a>. | ||
| Proof-of-work has now been deprecated. Ethereum no longer uses proof-of-work as part of its consensus mechanism. Instead, it uses proof-of-stake. Read more on [proof-of-stake](/developers/docs/consensus-mechanisms/pos/) and [staking](/staking/). |
There was a problem hiding this comment.
Did this change with our Next.js mdx updates? We previously were forced to use html when inside JSX components since the MD wouldn't parse, but looks like this is working great 👍 Much cleaner
There was a problem hiding this comment.
Im not entirely sure why this changed, but was working for me so just went for it
There was a problem hiding this comment.
❤️
Nice... so looks like this preserves backward-compatibility with the existing usage of asChild, but if I'm correct, we could have a separate task to refactor those so they remove asChild and the nested usage of BaseLink?
ie, src/components/ui/avatar.tsx
<LinkOverlay
asChild
className={cn(
"peer z-overlay inline-flex items-center gap-1 p-1",
size !== "md" ? "text-xs" : "text-sm"
)}
>
<BaseLink {...commonLinkProps}>{label}</BaseLink>
</LinkOverlay>could refactor to
<LinkOverlay
className={cn(
"peer z-overlay inline-flex items-center gap-1 p-1",
size !== "md" ? "text-xs" : "text-sm"
)}
{...commonLinkProps}
>
{label}
</LinkOverlay>That would be my goal to help clean this up and make it a bit more DRY, but wouldn't do it in this PR, just noting.
There was a problem hiding this comment.
Yeah want to come back and clean up the rest, but didnt want to scope creep too hard at the same time 😅
2 participants
Semrush warning category for SEO