Skip to content

feat: translate countries in get-eth dropdown#16014

Merged
wackerow merged 3 commits into
ethereum:devfrom
JoeChenJ:Countries_translation
Aug 6, 2025
Merged

feat: translate countries in get-eth dropdown#16014
wackerow merged 3 commits into
ethereum:devfrom
JoeChenJ:Countries_translation

Conversation

@JoeChenJ
Copy link
Copy Markdown
Contributor

@JoeChenJ JoeChenJ commented Aug 4, 2025

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 4, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 91e93a4
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6893c2b8b42bd50008668c63
😎 Deploy Preview https://deploy-preview-16014--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 55 (🟢 up 3 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Aug 4, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice job @JoeChenJ! ❤️ the JS native approach here to the extent possible. Pulling in

@wackerow wackerow merged commit a8cf583 into ethereum:dev Aug 6, 2025
6 of 7 checks passed
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Aug 6, 2025

@all-contributors please add @JoeChenJ for bug fix and code

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @JoeChenJ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: translate countries in get eth dropdown

2 participants