Skip to content

Apps learn page#15946

Merged
corwintines merged 8 commits into
dapps-revampfrom
apps-learn-page
Aug 7, 2025
Merged

Apps learn page#15946
corwintines merged 8 commits into
dapps-revampfrom
apps-learn-page

Conversation

@corwintines
Copy link
Copy Markdown
Member

@corwintines corwintines commented Jul 28, 2025

Description

Adds new learn page content for apps

https://deploy-preview-15946--ethereumorg.netlify.app/en/what-are-apps

@corwintines corwintines changed the base branch from dev to dapps-revamp July 28, 2025 05:01
@github-actions github-actions Bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jul 28, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 28, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6889a4438e6db1bc36dd3bb2
😎 Deploy Preview https://deploy-preview-15946--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@konopkja
Copy link
Copy Markdown
Contributor

not working - i think something is broken, it cant find the page

@corwintines
Copy link
Copy Markdown
Member Author

Sorry @konopkja, think theres a clash with how the /apps/{appname} and /apps/learn page routes are being generated. This is working locally, but something happens during build. Taking a look at whats going on here.

@wackerow
Copy link
Copy Markdown
Member

@konopkja Try new link per discussion

https://deploy-preview-15946--ethereumorg.netlify.app/en/what-are-apps

Patched with the following:

  • Updated /learn "dapps" card to point to /what-are-apps instead, aligning the link from /learn to a learn page (instead of the app explorer)
  • Added "Ethereum applications" to the use-cases dropdown menu since we're using that template
  • Refactored file structure to remove the "catch-all" (... in [...slug]) route segments, using a simple named string param instead (feel free to revert if there are plans to expand with deeper slug nesting)
  • Couple string updates with the new links?

@konopkja
Copy link
Copy Markdown
Contributor

Screenshot 2025-07-30 at 23 41 09

this is too hard to read if this is dark mode body medium, then we should switch it just to default body color

@konopkja
Copy link
Copy Markdown
Contributor

Screenshot 2025-07-30 at 23 42 22

it misses the stories here, i suppose thats still pending implementation?

@konopkja
Copy link
Copy Markdown
Contributor

@wackerow "Added "Ethereum applications" to the use-cases dropdown menu since we're using that template"

i dont think it should be in that drop down, this template is something we might want to use in other areas of the website visually. Another example of this is the learn hub that doesnt have the dropdown

@corwintines
Copy link
Copy Markdown
Member Author

Addressed the comments here. @konopkja I sent you a message to sort out the stories part of this.

Going to merge into main apps revamp branch for preview deploy purposes.

@corwintines corwintines merged commit 9ff7ea9 into dapps-revamp Aug 7, 2025
2 checks passed
@corwintines corwintines deleted the apps-learn-page branch August 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants