Fix torch history card date display and placeholder messaging#15886
Closed
minimalsm wants to merge 3 commits into
Closed
Fix torch history card date display and placeholder messaging#15886minimalsm wants to merge 3 commits into
minimalsm wants to merge 3 commits into
Conversation
minimalsm
requested review from
corwintines,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
minimalsm
commented
Jul 20, 2025
Comment on lines
+26
to
+28
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return `${num}th`; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
will never happen as num will range from 20 to 30
pettinarip
previously approved these changes
Jul 20, 2025
wackerow
reviewed
Jul 20, 2025
minimalsm
commented
Jul 21, 2025
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Contributor
Author
|
Closing in favour of #15900 |
github-actions
Bot
added
the
abandoned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1: Redundant date display for current torchbearers
Problem: Currently, torch history cards display "From [date] to [date]" even when the torchbearer still holds the NFT. When someone is the current holder, both dates are identical, creating confusing and redundant text.
Solution: Conditionally render the date text based on isCurrentHolder prop:
Current holders: Show "From [date]" only
Previous holders: Show "From [date] to [date]" range
Fix 2: Generic placeholder messaging
Problem: All future torchbearer placeholders show the same generic "Coming soon!" message, providing no indication of when each person will receive the torch.
Solution: Replace generic messaging with specific dates showing when each torchbearer will receive the torch:
Torchbearer 1: "Coming 20th!"
Torchbearer 2: "Coming 21st!"
Torchbearer 3: "Coming 22nd!"
And so on...