Skip to content

feat(find-wallet): Add privacy filter#15873

Merged
wackerow merged 3 commits into
ethereum:devfrom
Savio-Sou:ss/add-privacy-wallet-filter
Sep 10, 2025
Merged

feat(find-wallet): Add privacy filter#15873
wackerow merged 3 commits into
ethereum:devfrom
Savio-Sou:ss/add-privacy-wallet-filter

Conversation

@Savio-Sou
Copy link
Copy Markdown
Contributor

@Savio-Sou Savio-Sou commented Jul 18, 2025

Description

Adds an optional "Privacy" wallet property and a filter under the "Smart contract" section for tagging and filtering wallets supporting built-in private transactions.

No wallets are tagged / added in this PR by intention to keep the PR simple to review. To try the filter out, add privacy: true, to a random wallet in wallet-data.ts and build the website locally.

Preview link

https://deploy-preview-15873--ethereumorg.netlify.app/en/wallets/find-wallet

Related Issue

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 18, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7416fa0
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68c15a8c94d7e500094cc945
😎 Deploy Preview https://deploy-preview-15873--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 28 (🔴 down 16 from production)
Accessibility: 90 (🔴 down 5 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 97 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jul 18, 2025
@wackerow wackerow added feature ✨ This is enhancing something existing or creating something new config ⚙️ Changes to configuration files and removed content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program tooling 🔧 Changes related to tooling of the project labels Aug 1, 2025
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Aug 1, 2025

Thanks @Savio-Sou! At a glance this looks good, and I personally love the direction.

@konopkja Mind weighing in here? This PR effectively adds a privacy feature filter. Currently none are marked with it, which was intentional for the PR (but is also likely completely accurate tbh), so checking it would immediately yield "no results".

@Savio-Sou did you have any existing wallets in mind that would fit this? "Wallets that support built-in private transactions" feels a touch vague... I'm not quite sure what this would mean. A "private RPC"? ZK proofs are involved? Curious your thoughts here

Personally love the idea of adding something like this to, at the least, surface it as an important feature... and secondly, to give wallet providers something to strive for since actual respect for privacy in wallet apps is extremely hard to find, and a ❌ Privacy next to their wallet name could help motivate, since human decency doesn't. I'm not sure how I feel though about adding a flag that yields no results though, that's bad UX, so curious the apps @Savio-Sou you may be thinking for this to potentially launch with.

@Savio-Sou
Copy link
Copy Markdown
Contributor Author

Savio-Sou commented Aug 1, 2025

@Savio-Sou did you have any existing wallets in mind that would fit this?

Railway, Payy, Obsidion, and AzGuard are ones that I'm aware of that supports private transactions built-in.

Intentionally left adding them to the wallet list out of this PR to keep things clean. Happy to follow up with separate PRs adding them.

"Wallets that support built-in private transactions" feels a touch vague... I'm not quite sure what this would mean. A "private RPC"? ZK proofs are involved?

Private transactions using ZKPs to conceal senders and/or amounts, yes. I personally won't consider the mere use of private RPC for sending transactions to be private transactions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 1, 2025

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 1, 2025
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 10, 2025
Re-enable when at least one privacy-enabled wallet is listed
@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Sep 10, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @Savio-Sou...

Per discussion with @konopkja, I've commented out this filter while we're awaiting the listing of at least one privacy-enabled wallet.

@Savio-Sou https://github.com/ethereum/ethereum-org-website/issues/new?template=suggest_wallet.yaml This is the issue template for these—would you have any interest in filling these out for any or all of the wallet suggestions you made?

e.g.

Merging in the meantime! 🎉

@wackerow wackerow merged commit 31d197b into ethereum:dev Sep 10, 2025
6 of 7 checks passed
@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @Savio-Sou for code

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @Savio-Sou! 🎉

@corwintines corwintines mentioned this pull request Sep 10, 2025
@Savio-Sou Savio-Sou deleted the ss/add-privacy-wallet-filter branch September 29, 2025 20:38
@Savio-Sou
Copy link
Copy Markdown
Contributor Author

Thanks @wackerow, created #16392 as a starting private wallet entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "Privacy" wallet filter

2 participants