feat(find-wallet): Add privacy filter#15873
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks @Savio-Sou! At a glance this looks good, and I personally love the direction. @konopkja Mind weighing in here? This PR effectively adds a @Savio-Sou did you have any existing wallets in mind that would fit this? "Wallets that support built-in private transactions" feels a touch vague... I'm not quite sure what this would mean. A "private RPC"? ZK proofs are involved? Curious your thoughts here Personally love the idea of adding something like this to, at the least, surface it as an important feature... and secondly, to give wallet providers something to strive for since actual respect for privacy in wallet apps is extremely hard to find, and a |
Railway, Payy, Obsidion, and AzGuard are ones that I'm aware of that supports private transactions built-in. Intentionally left adding them to the wallet list out of this PR to keep things clean. Happy to follow up with separate PRs adding them.
Private transactions using ZKPs to conceal senders and/or amounts, yes. I personally won't consider the mere use of private RPC for sending transactions to be private transactions. |
|
This issue is stale because it has been open 30 days with no activity. |
Re-enable when at least one privacy-enabled wallet is listed
wackerow
left a comment
There was a problem hiding this comment.
Looks great! Thanks again @Savio-Sou...
Per discussion with @konopkja, I've commented out this filter while we're awaiting the listing of at least one privacy-enabled wallet.
@Savio-Sou https://github.com/ethereum/ethereum-org-website/issues/new?template=suggest_wallet.yaml This is the issue template for these—would you have any interest in filling these out for any or all of the wallet suggestions you made?
e.g.
Merging in the meantime! 🎉
|
@all-contributors please add @Savio-Sou for code |
|
I've put up a pull request to add @Savio-Sou! 🎉 |

Description
Adds an optional "Privacy" wallet property and a filter under the "Smart contract" section for tagging and filtering wallets supporting built-in private transactions.
No wallets are tagged / added in this PR by intention to keep the PR simple to review. To try the filter out, add
privacy: true,to a random wallet in wallet-data.ts and build the website locally.Preview link
https://deploy-preview-15873--ethereumorg.netlify.app/en/wallets/find-wallet
Related Issue