Skip to content

intl(zh): fix translation#15806

Merged
wackerow merged 2 commits into
ethereum:devfrom
shynur:dev
Sep 10, 2025
Merged

intl(zh): fix translation#15806
wackerow merged 2 commits into
ethereum:devfrom
shynur:dev

Conversation

@shynur
Copy link
Copy Markdown
Contributor

@shynur shynur commented Jul 10, 2025

'应用程序' means 'application software' in Chinese, which is a completely wrong translation.

'APPLY 调用' means 'a call to APPLY', which is better and correct.

'应用程序' means 'application software' in Chinese.

'`APPLY` 调用' means 'a call to `APPLY`', which is better.
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 10, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit fe9076a
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6870fdeeb8a68a00084729f9
😎 Deploy Preview https://deploy-preview-15806--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 59 (🟢 up 11 from production)
Accessibility: 96 (🟢 up 2 from production)
Best Practices: 91 (🔴 down 1 from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jul 10, 2025
3. 检查区块上的工作量证明是否有效。
4. 令前一个区块末尾的态为 `S[0]`。
5. 假设 `TX` 是该区块的交易列表,其中包含 `n` 个交易。 对于 `0...n-1` 中的所有 `i`,如果有任何应用程序返回错误,退出并返回 false,请设置 `S[i+1] = APPLY(S[i],TX[i])`。
5. 假设 `TX` 是该区块的交易列表,其中包含 `n` 个交易。 对于 `0...n-1` 中的所有 `i`,如果有任何 `APPLY` 调用返回错误,退出并返回 false,请设置 `S[i+1] = APPLY(S[i],TX[i])`。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes absolute sense! And I suggest reordering the sentence to make it even more readable:

假设 TX 是该区块的交易列表,其中包含 n 个交易。 对于 0...n-1 中的所有 i,执行 S[i+1] = APPLY(S[i],TX[i]),如果有任何 APPLY 调用返回错误,则退出并返回 false 。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好, 已经重排序, 顺便稍微改了下措辞.

@wackerow
Copy link
Copy Markdown
Member

Thanks @shynur! Appreciate the suggestion...

cc: @lukassim Can you remind me if we have any flow established for whitepaper translations? This looks reasonable, but we tend to not mess with this page. If we're good with it, we should upload this to Crowdin to prevent it from getting reverted when Crowdin syncs with the repo.

@Clashinm
Copy link
Copy Markdown

Clashinm commented Jul 15, 2025 via email

@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 15, 2025
@wackerow wackerow changed the title ; fix translation zh_CN intl(zh): fix translation Sep 10, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review

Here’s a review of the Chinese Simplified translation update for the canonical English string:

Canonical English:

  1. Suppose TX is the block's transaction list with n transactions. For all i in 0...n-1, set S[i+1] = APPLY(S[i],TX[i]) If any application returns an error, exit and return false.

Old Translation

  1. 假设 TX 是该区块的交易列表,其中包含 n 个交易。 对于 0...n-1 中的所有 i,如果有任何应用程序返回错误,退出并返回 false,请设置 S[i+1] = APPLY(S[i],TX[i])
  • Issues:
    • The logical order is incorrect. It suggests checking for errors before performing the APPLY operation, which does not match the English.
    • "应用程序" (“application”) is ambiguous and not appropriate for this technical context.
    • The sentence is convoluted and harder to understand.

New Translation

  1. 假设 TX 是该区块的交易列表,其中包含 n 个交易。 对于 0...n-1 中的每个数字 i,依次执行 S[i+1] = APPLY(S[i],TX[i])。 如果有任何一次对 APPLY 的调用返回了错误,退出并返回 false。
  • Improvements:
    • Correctly describes the process: for each i, execute APPLY, then check for errors.
    • The phrase “依次执行” (“execute in sequence”) makes the iteration clear.
    • “任何一次对 APPLY 的调用返回了错误” clearly states the error condition and matches the English intent.
    • Removes the awkward “应用程序” phrasing.

Summary

The new translation is accurate, clear, and matches the intent and logical flow of the original English.
Recommendation: Use the new translation.

Copilot recommendation: "Use the new translation."


Looks good! Thanks @shynur and @JoeChenJ!

@wackerow wackerow merged commit 2a59d65 into ethereum:dev Sep 10, 2025
6 checks passed
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Sep 10, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @shynur for translations

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @shynur! 🎉

@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @JoeChenJ for translations

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @JoeChenJ! 🎉

This was referenced Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits Status: Stale This issue is stale because it has been open 30 days with no activity. translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants