Skip to content

fix: sorting using pre-translated dates #15687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 1 commit into from
Jun 19, 2025
Merged

fix: sorting using pre-translated dates #15687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/lib/utils/rss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@ import type { Lang, RSSItem } from "../types"
import { isValidDate } from "./date"
import { getLocaleTimestamp } from "./time"

export const sortByPubDate = (items: RSSItem[]) =>
// Sort by original pubDate string (not yet localized)
export const sortByPubDateRaw = (items: (RSSItem & { pubDateRaw: string })[]) =>
items.sort((a, b) => {
const dateA = new Date(a.pubDate)
const dateB = new Date(b.pubDate)
const dateA = new Date(a.pubDateRaw)
const dateB = new Date(b.pubDateRaw)
if (isNaN(dateA.getTime()) || isNaN(dateB.getTime())) {
console.error("Invalid date found:", a.pubDate, b.pubDate)
console.error("Invalid date found:", a.pubDateRaw, b.pubDateRaw)
return 0
}
return dateB.getTime() - dateA.getTime()
Expand All @@ -20,7 +21,7 @@ export const postProcess = (rssItems: RSSItem[], locale: Lang) =>
const pubDate = isValidDate(item.pubDate)
? getLocaleTimestamp(locale, item.pubDate)
: ""
const formattedItem = { ...item, pubDate }
const formattedItem = { ...item, pubDate, pubDateRaw: item.pubDate }

switch (item.sourceFeedUrl) {
case VITALIK_FEED:
Expand All @@ -47,5 +48,5 @@ export const polishRSSList = (items: RSSItem[][], locale: Lang) => {

const latestItems = latestOfEach.flat()
const readyForSorting = postProcess(latestItems, locale)
return sortByPubDate(readyForSorting)
return sortByPubDateRaw(readyForSorting)
}