Fix home hero#15681
Merged
Merged
Conversation
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
commented
Jun 18, 2025
| reactDocgen: "react-docgen-typescript", | ||
| }, | ||
| features: { | ||
| experimentalRSC: true, |
Member
Author
There was a problem hiding this comment.
Im adding this experimental flag for future stories that may use RSC but it didn't work for the home hero. That is why Im removing it for now until we have a solution.
ref https://storybook.js.org/docs/get-started/frameworks/nextjs#react-server-components-rsc
pettinarip
commented
Jun 18, 2025
| const HomeHero = ({ heroImg, className }: HomeHeroProps) => { | ||
| const { t } = useTranslation("page-index") | ||
| const HomeHero = async ({ heroImg, className, locale }: HomeHeroProps) => { | ||
| const t = await getTranslations({ locale, namespace: "page-index" }) |
Member
Author
There was a problem hiding this comment.
Tried to use getLocale but it was not matching the locale in the url 🤷🏼
corwintines
approved these changes
Jun 18, 2025
This was referenced Jun 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description