Skip to content

Add section in Smart Contracts section on Smart Contract Naming#15643

Merged
wackerow merged 6 commits into
ethereum:devfrom
conor10:dev
Sep 9, 2025
Merged

Add section in Smart Contracts section on Smart Contract Naming#15643
wackerow merged 6 commits into
ethereum:devfrom
conor10:dev

Conversation

@conor10
Copy link
Copy Markdown
Contributor

@conor10 conor10 commented Jun 9, 2025

Description

This creates a new sub-section "Naming smart contracts" in the Smart Contracts section of the docs.

Related Issue

This fixes #15641.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 9, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7ece583
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68c002901e9fc700083ebb23
😎 Deploy Preview https://deploy-preview-15643--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 53 (🟢 up 9 from production)
Accessibility: 90 (🔴 down 5 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 97 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 9, 2025
Copy link
Copy Markdown

@joeurassa joeurassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @conor10

@conor10
Copy link
Copy Markdown
Contributor Author

conor10 commented Jun 23, 2025

Hi, would it be possible to get additional reviews for this PR with a view to merging it? 🙏🏻

@conor10
Copy link
Copy Markdown
Contributor Author

conor10 commented Jul 10, 2025

Hi @corwintines, @pettinarip, @minimalsm and @wackerow could I possibly get a review for this now?

Copy link
Copy Markdown
Contributor

@konopkja konopkja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@conor10
Copy link
Copy Markdown
Contributor Author

conor10 commented Jul 22, 2025

lgtm

@konopkja does this mean the issue can now be merged?

@konopkja
Copy link
Copy Markdown
Contributor

lgtm

@konopkja does this mean the issue can now be merged?

From my perspective its ready, now a dev needs to code review and merge, maybe my team mates during that process will have additional review comments.

@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 22, 2025
@conor10
Copy link
Copy Markdown
Contributor Author

conor10 commented Aug 22, 2025

Still waiting approval checks — it shouldn't be marked stale.

@github-actions github-actions Bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 23, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed some minor patches to clean things up and make consistent with site style guide. Lgtm! Thanks @conor10

@wackerow wackerow merged commit 69d1a15 into ethereum:dev Sep 9, 2025
3 checks passed
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Sep 9, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

@wackerow
Copy link
Copy Markdown
Member

wackerow commented Sep 9, 2025

@all-contributors please add @conor10 for content

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

@conor10 already contributed before to content

This was referenced Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new page in Smart Contract section on Smart Contract Naming

4 participants