refactor: Developers page to SSR#15629
Merged
Merged
Conversation
SSR expects final string values for title and description; Callout remains as-named for better backward compatibility, and expects a translation key for title and description to look up the final string client-side, passing that to the SSR version for canonical styling.
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fix: common namespace string; fix: duplicate usage of MainArticle (not allowed; contains `id`); fix: inconsistent spacing
pettinarip
approved these changes
Jun 9, 2025
Member
There was a problem hiding this comment.
In theory we could just use this one in all the instances, right? we should pass the translated strings.
This was referenced Jun 12, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_components/developers.tsxCallouttoCallout+CalloutSSR: SSR version expects final string values for title and description; Callout remains as-named for better backward compatibility, and expects a translation key for title and description to look up the final string client-side, passing that to the SSR version for canonical styling.Related Issue
Ongoing performance initiatives