fix: internal tutorials on /tutorials landing page, lazy load ui#15616
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tutorials are publicly served at URL/content/developers/tutorials/<name>/index.md in production. Netlify to generate appropriate /tutorials landing page based on committed list of tutorials from local fs.
Quickly logs output of `ls` to .json file with list of available nested /tutorials folders
github-actions
Bot
added
the
dependencies 📦
wackerow
changed the title
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
avoids footer components flashing on larger screens.
pettinarip
reviewed
Jun 27, 2025
| npx lint-staged No newline at end of file | ||
| npx lint-staged | ||
| pnpm update-tutorials | ||
| git add src/data/internalTutorials.json |
Member
There was a problem hiding this comment.
Im fine with the current solution but not this part. IMO this will affect the DX and encourage ppl to just skip these hooks.
I'd prefer to call this manually as part of the process of adding a new tutorial. We should update the docs to highlight this.
Member
Author
There was a problem hiding this comment.
Agree with this approach! Will patch
pettinarip
approved these changes
Jun 30, 2025
This was referenced Jul 16, 2025
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ls public/content/developers/tutorialsinto a json data array of all available internal tutorials./content/developers/tutorials/path instead of attempting to have Netlify read fromfsat build time.Preview link
https://deploy-preview-15616--ethereumorg.netlify.app/en/developers/tutorials
Related Issue
Fixes internal tutorials not being loaded into list of tutorials on https://ethereum.org/en/developers/tutorials