config: update eslint 8.57.1, pnpm 10.11.1#15609
Merged
Merged
Conversation
latest version with next.js support
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
config ⚙️
wackerow
changed the title
unused-imports/no-unused-imports-ts -> unused-imports/no-unused-imports as of eslint-plugin-unused-imports v3
wackerow
changed the title
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates development tooling versions and refactors lint/config settings for consistency.
- Bumps
eslintto 8.57.1 andpnpmto 10.11.1, plus adjusts related package versions. - Enables NVM in builds via
.mise.tomland updates.nvmrcnode version. - Refactors code to use blank placeholders in destructuring and cleans up ESLint config.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/scripts/markdownChecker.ts | Commented-out unused constant; removed ESLint disable. |
| src/lib/utils/wallets.ts | Replaced [_ , value] with [, value] for destructuring. |
| src/hooks/useClipboard.ts | Replaced [_, copy] with [, copy] placeholder. |
| src/components/ui/chart.tsx | Replaced [_, config] with [, config] placeholder. |
| src/components/Quiz/QuizWidget/index.tsx | Replaced [_, updateUserStats] with [, updateUserStats]. |
| src/components/FindWalletProductTable/hooks/useWalletFilters.tsx | Removed unused parameter in arrow func. |
| package.json | Version bumps for ESLint plugins, ESLint, and pnpm in packageManager. |
| .nvmrc | Updated Node version to 20.19.2. |
| .mise.toml | Added NVM integration settings. |
| .eslintrc.json | Refactored top-level extends, added parserOptions, and reorganized rules/overrides. |
Comment on lines
70
to
74
| // ! Current usage of this const is commented out | ||
| // eslint-disable-next-line unused-imports/no-unused-vars | ||
| const CASE_SENSITIVE_SPELLING_MISTAKES = ["Thereum", "Metamask", "Github"] | ||
| // const CASE_SENSITIVE_SPELLING_MISTAKES = ["Thereum", "Metamask", "Github"] | ||
| // Ideas: | ||
| // Regex for explicit lang path (e.g. /en/) && for glossary links (trailing slash breaks links e.g. /glossary/#pos/ doesn't work) | ||
| // We should have case sensitive spelling mistakes && check they are not in links. |
There was a problem hiding this comment.
Consider removing this commented-out constant (and its unused ESLint disable comment) entirely to keep the codebase clean, or reintroduce its usage if still intended.
corwintines
approved these changes
Jun 10, 2025
This was referenced Jun 12, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally included
nodebump to 22, but ran into memory issues related to static site generation that needs investigation first. (Ignore branch name 😄)