feat: upgrade package manager to pnpm#15546
Merged
Merged
Conversation
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
config ⚙️
pettinarip
approved these changes
Jun 2, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Good job @wackerow! thanks for the migration and lodash normalization :)
Left a comment about something related to crowdin that seems unrelated to the pnpm migration. Could you elaborate more on those changes?
| export const CROWDIN_PROJECT_ID = 363359 | ||
| export const CROWDIN_API_MAX_LIMIT = 500 | ||
| export const FIRST_CROWDIN_CONTRIBUTION_DATE = "2019-07-01T00:00:00+00:00" | ||
| export const REGULAR_RATES: ReportsModel.RegularRate[] = [ |
| // https://github.com/crowdin/crowdin-api-client-js/pull/282 | ||
| const schema: ReportsModel.TranslationCostSchema = { | ||
| // const schema: ReportsModel.TranslationCostSchema = { | ||
| const schema: ReportsModel.TranslationCostsPostEndingSchema = { |
Member
There was a problem hiding this comment.
this doesn't seem the PR to include this change. do we need to test something? not sure what this change is doing
Member
Author
There was a problem hiding this comment.
There were some changes to the data schema required from the crowdin package. We can check with @lukassim but I'm not sure we really even use this anymore, but in the meantime I tried my best o update to match the new schema.
This was referenced Jun 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pnpmas canonical package manager. Dependency requirements are a bit different withpnpmcompared toyarn, and all package versions have been updated accordingly to comply.corepackfor package manager version control; version maintained inpackage.json(Enable withcorepack enable)yarnand updated topnpminstructions