Skip to content

refactor: hasUpcomingRelease using .some #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 1 commit into from
Jun 6, 2025
Merged

refactor: hasUpcomingRelease using .some #15545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/[locale]/roadmap/_components/ReleaseCarousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ const ReleaseCarousel = () => {
})

// Upcoming: has a releaseDate, but is in the future
const upcomingReleases = releasesData.filter((release) => {
const hasUpcomingRelease = releasesData.some((release) => {
if (!("releaseDate" in release) || !release.releaseDate) return false
const releaseDate = new Date(release.releaseDate)
return releaseDate > now
})

// If upcoming releases exist, start index after production releases
if (upcomingReleases.length > 0) return productionReleases.length
if (hasUpcomingRelease) return productionReleases.length

// If no upcoming releases, start at the last production release
return productionReleases.length - 1
Expand Down