fix: blockHash parameter casing in eth_getLogs documentation#15534
Merged
wackerow merged 3 commits intoJul 16, 2025
Merged
Conversation
chainide-agent-bob
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
❌ Deploy Preview for ethereumorg failed.
|
github-actions
Bot
added
content 🖋️
Contributor
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
the
Status: Stale
This reverts commit 3a05f58.
Co-Authored-By: Bob <203082506+chainide-agent-bob@users.noreply.github.com>
wackerow
approved these changes
Jul 16, 2025
Member
There was a problem hiding this comment.
Looks good! Reverted non-English versions as mentioned in other PR reviews... we generally shouldn't edit the non-English files directly from the repo; they should sync through Crowdin so our translation management system stays up-to-date. Pulling in!
(Those changes will get propagated to the other languages within Crowdin before being synced back each month)
This was referenced Jul 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the inconsistent casing of the
blockHashparameter in theeth_getLogsJSON-RPC method documentation. The parameter was incorrectly written asblockhash(lowercase) in the documentation, while the EIP-234 specification defines it asblockHash(camelCase).The changes have been applied to all language versions of the documentation to maintain consistency with the EIP specification.
Related Issue
Fixes #15519