fix: quotes escaping in German gas page link [FIXES #15349]#15350
Merged
corwintines merged 1 commit intoMay 21, 2025
Merged
Conversation
chainide-agent-bob
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
Bot
added
the
translation 🌍
corwintines
approved these changes
May 21, 2025
This was referenced May 28, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixed quote escaping in the German translation file (
src/intl/de/page-gas.json) where link quotes were not properly escaped.Solution
Modified line 56 to change the link format from
href="/developers/docs/gas/"to the correct formathref=\"/developers/docs/gas/\"to ensure proper JSON formatting. Also fixed the quote escaping in thetranslate="no"attribute.Before:
After:
Fixes
#15349