Skip to content

SEO: filter invalid locales from alternates#15200

Merged
wackerow merged 3 commits into
devfrom
patch-hreflang-invalid-locales
May 28, 2025
Merged

SEO: filter invalid locales from alternates#15200
wackerow merged 3 commits into
devfrom
patch-hreflang-invalid-locales

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented Mar 28, 2025

Description

  • adds validISO639_1 prop to each language config
  • updates PageMetadata to filter locales from alternate metatags

@github-actions github-actions Bot added config ⚙️ Changes to configuration files tooling 🔧 Changes related to tooling of the project labels Mar 28, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 28, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2dbb2cc
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68372d7a5ad6290008dd1d8b
😎 Deploy Preview https://deploy-preview-15200--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 38 (🔴 down 17 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 89 (🔴 down 10 from production)
SEO: 99 (🔴 down 1 from production)
PWA: 59 (🟢 up 1 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip changed the title SEO: filter non-valid locales from alternates SEO: filter invalid locales from alternates Mar 28, 2025
minimalsm
minimalsm reviewed Mar 28, 2025
View reviewed changes
Comment thread i18n.config.json
"langDir": "ltr",
"dateFormat": "MM/DD/YYYY"
"dateFormat": "MM/DD/YYYY",
"validISO639_1": true
Copy link
Copy Markdown
Contributor

@minimalsm minimalsm Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why include this for all instead of just adding invalidISO0639_1 to pcm and fil?

Copy link
Copy Markdown
Member Author

@pettinarip pettinarip Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer a consistent scheme for better typing, and usually go with positive names for clearer logic. That said, I'm not strongly attached to it. Happy to switch to your suggestion if you feel strongly about it.

Copy link
Copy Markdown
Member

@wackerow wackerow May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 of one, half a dozen of the other... just a data file, fine with it as is myself.

corwintines
corwintines approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is so will approve, but saw @minimalsm comment so will leave open in case you make changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2025

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 16, 2025
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 28, 2025
@wackerow wackerow merged commit 0fe0020 into dev May 28, 2025
6 checks passed
@wackerow wackerow deleted the patch-hreflang-invalid-locales branch May 28, 2025 16:46
@pettinarip pettinarip mentioned this pull request May 28, 2025
Merged
This was referenced May 28, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minimalsm minimalsm minimalsm left review comments

@wackerow wackerow wackerow approved these changes

+2 more reviewers

@corwintines corwintines corwintines approved these changes

@Memohalliwell Memohalliwell Memohalliwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

config ⚙️ Changes to configuration files tooling 🔧 Changes related to tooling of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pettinarip @corwintines @wackerow @minimalsm @Memohalliwell