WIP build optimizations on non-prod envs#15158
Closed
pettinarip wants to merge 8 commits into
Closed
Conversation
pettinarip
force-pushed
the
build-only-default-locale
branch
from
be6798f to
3c454ad
Compare
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
force-pushed
the
build-only-default-locale
branch
from
3c454ad to
f2b4bc6
Compare
wackerow
approved these changes
Mar 26, 2025
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
👍 Looks great! Working well locally; consider it approved. @pettinarip Will leave it up to you if you want to merge app-router-pages (#15114) target branch first, or pull this into that PR.
|
|
||
| const USE_MOCK_DATA = process.env.USE_MOCK_DATA === "true" | ||
|
|
||
| if (USE_MOCK_DATA) { |
Member
There was a problem hiding this comment.
nice, just noting a similar change was made in #15160 so there may be a tiny conflict here
Contributor
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
the
Status: Stale
wackerow
removed
the
Status: Stale
Member
|
#15160 has been merged... if we still want this just need to clear conflicts, update name and flip to ready for review and we'll get it in 🙏 |
github-actions
Bot
added
the
abandoned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unifies the dynamic pages logic (slug, docs, tutorials) to simplify the build strategy in one place.
New strat: