Start with Ethereum web3#14947
Merged
Merged
Conversation
corwintines
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
github-actions
Bot
added
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
Bot
added
content 🖋️
Afeter8
approved these changes
Mar 5, 2025
pettinarip
reviewed
Mar 13, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@corwintines gj! left a few thoughts, overall looks great.
…deploy on Netlify
pettinarip
approved these changes
Mar 21, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
@corwintines thanks for the adjustments. Looks good on my side. I'm pushing two minor commits to polish the things mentioned.
| height={30} | ||
| /> | ||
| </div> | ||
| <p className="text-body">{wallet.name}</p> |
Member
There was a problem hiding this comment.
The LinkBox is fine but we are missing the LinkOverlay that needs to wrap the description/text for the link. Pushing a commit for this.
|
|
||
| return ( | ||
| <QueryClientProvider client={queryClient}> | ||
| <WalletProviders locale={router.query.locale as string}> |
Member
There was a problem hiding this comment.
We should use now the useLocale hook to get it. Pushing a commit for this as well.
This was referenced Mar 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-14947--ethereumorg.netlify.app/en/start/