Conversation
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
Bot
added
content 🖋️
|
|
||
| We want to make sure we list the best resources possible while keeping users safe and confident. | ||
|
|
||
| Anyone is free to suggest new resources to add to the resource dashboard on ethereum.org, currently found at [ethereum.org/resources](/resources/). |
There was a problem hiding this comment.
@nloureiro any thoughts on what we should call this page? resources doesnt seem right, but @wackerow mentioned that he feels the same about ethereum.org 'dashboard'
There was a problem hiding this comment.
Yeah, would suggest perhaps a redirect from /dashboards/ -301-> /resources/ if we want to use that
| - _Inspirational_: anything on ethereum.org should offer something new to users | ||
| - _A good story_: what's listed should provide an "aha" moment |
There was a problem hiding this comment.
Not saying we removed it, but this seems less true in dashboards than elsewhere. Perhaps because dashboards is a more 'advanced page'
Co-Authored-By: Joshua <62268199+minimalsm@users.noreply.github.com>
|
|
||
| const data = [{ value }] | ||
|
|
||
| if (!isMounted) return null |
There was a problem hiding this comment.
Noting a bit of layout shift. Wondering why do we need this.
There was a problem hiding this comment.
Good catch and agree; will table this for future iteration, cc: @TylerAPfledderer
There was a problem hiding this comment.
Noting that this chart and the AreaChart are wrapped with a Card component but not the Radial one.
I'd lean towards keeping the charts and dumb as possible (exporting just the chart) and control the wrapping elements/styles from the outside. To make it more reusable in the future.
There was a problem hiding this comment.
Good catch and agree; will table this for future iteration, cc: @TylerAPfledderer
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
|
@pettinarip @wackerow now that this is merged, I will look to a new PR for future iteration, and referring comments made here. @corwintines so it's clear for you: for the next QA session, it should just focus on items on this page that might be breaking logic or severely break the UX; no attention to anything that I will attend to later with design refinement |
5 participants
Description
/resources/page MVPpublic/content/contributing/adding-resources/index.mddetailing the policy and criteria for adding resources to ethereum.org.AreaChart,BarChartandRadialChartcomponents/dashboards/as alternate pathPreview link
New page: https://deploy-preview-14942--ethereumorg.netlify.app/en/resources
Linked from: https://deploy-preview-14942--ethereumorg.netlify.app/en/#activity