Skip to content

refactor(link-box): use asChild strategy for LinkBox component#14937

Merged
pettinarip merged 3 commits into
ethereum:devfrom
TylerAPfledderer:refactor/linkbox-asChild-strat
Mar 10, 2025
Merged

refactor(link-box): use asChild strategy for LinkBox component#14937
pettinarip merged 3 commits into
ethereum:devfrom
TylerAPfledderer:refactor/linkbox-asChild-strat

Conversation

@TylerAPfledderer
Copy link
Copy Markdown
Contributor

Description

Updates the LinkBox component to us the asChild strategy employed by the other UI components

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit fa3576f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67cdc6e27822b90008185663
😎 Deploy Preview https://deploy-preview-14937--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 13 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer changed the title refactor(link-box): use asChild strategy for LinkBox` component refactor(link-box): use asChild strategy for LinkBox component Feb 19, 2025
Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@pettinarip pettinarip merged commit 90cbc7b into ethereum:dev Mar 10, 2025
@TylerAPfledderer TylerAPfledderer deleted the refactor/linkbox-asChild-strat branch March 10, 2025 17:43
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants