Skip to content

fix(fetchGitHistory): update github token env key name#14936

Merged
pettinarip merged 4 commits into
ethereum:devfrom
TylerAPfledderer:fix/fetchGitHistory-token-env
Mar 10, 2025
Merged

fix(fetchGitHistory): update github token env key name#14936
pettinarip merged 4 commits into
ethereum:devfrom
TylerAPfledderer:fix/fetchGitHistory-token-env

Conversation

@TylerAPfledderer
Copy link
Copy Markdown
Contributor

Description

In the fetchGitHistory function, a GITHUB_TOKEN_READ_ONLY env is set to a variable, when it should be NEXT_PUBLIC_GITHUB_READ_ONLY as shown in .env.example and used in other api functions.

Should a new user need to navigate to a developer tutorial page in the dev server, they will not see a fetch error and not become confused as to the token key usage or setup.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Feb 19, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9a4a481
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67cdc6c6185d12000855f09e
😎 Deploy Preview https://deploy-preview-14936--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 17 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review February 19, 2025 02:02
@pettinarip pettinarip merged commit 2c892c7 into ethereum:dev Mar 10, 2025
@TylerAPfledderer TylerAPfledderer deleted the fix/fetchGitHistory-token-env branch March 10, 2025 17:42
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants