Skip to content

[ShadCN]: remove Chakra Provider and Dependencies#14931

Merged
pettinarip merged 19 commits into
ethereum:devfrom
TylerAPfledderer:refactor/remove-chakra-all
Feb 18, 2025
Merged

[ShadCN]: remove Chakra Provider and Dependencies#14931
pettinarip merged 19 commits into
ethereum:devfrom
TylerAPfledderer:refactor/remove-chakra-all

Conversation

@TylerAPfledderer
Copy link
Copy Markdown
Contributor

Description

Removes the Chakra Provider, Theming config, and package dependencies.

useLocaleDirection now becomes just a trigger with no value returned, as the RTL direction only needs to be injected into the DOM on update.

This should be the final PR for the UI migration. What is left as a non-blocker is to update documentation about using Tailwind and Radix (ShadCN) in the stack, and any particular notes for DX in how they are being applied to this project (if there are any particulars)

@github-actions github-actions Bot added config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels Feb 18, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 18, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c9666c5
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67b4cd0aa0f9ac0008f7f70b
😎 Deploy Preview https://deploy-preview-14931--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 7 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer changed the title Refactor/remove chakra all [ShadCN]: remove Chakra Provider and Dependencies Feb 18, 2025
@wackerow
Copy link
Copy Markdown
Member

Let's gooo!! 🔥

Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Comment thread src/components/Nav/useNav.ts Outdated
Comment thread tailwind.config.ts Outdated
Comment thread src/theme.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh yes!

Comment thread src/styles/global.css
@layer base {
body {
@apply !bg-background font-body !text-body;
@apply bg-background font-body leading-base text-body;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@pettinarip pettinarip merged commit 9c83c19 into ethereum:dev Feb 18, 2025
@TylerAPfledderer TylerAPfledderer deleted the refactor/remove-chakra-all branch February 18, 2025 18:52
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants