Skip to content

[ShadCN]: Move Color Stories to Tailwind#14915

Merged
pettinarip merged 6 commits into
ethereum:devfrom
TylerAPfledderer:feat/color-stories-tailwind
Feb 17, 2025
Merged

[ShadCN]: Move Color Stories to Tailwind#14915
pettinarip merged 6 commits into
ethereum:devfrom
TylerAPfledderer:feat/color-stories-tailwind

Conversation

@TylerAPfledderer
Copy link
Copy Markdown
Contributor

@TylerAPfledderer TylerAPfledderer commented Feb 15, 2025

Description

Move color stories to Tailwind.

Had to create a function to retrieve the CSS variables via accessing the document, to then apply in rendering colors and labels.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Feb 15, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 15, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b11ea8c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67b344c1f037910008a01081
😎 Deploy Preview https://deploy-preview-14915--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 5 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread .storybook/main.ts Outdated
stories: [
"../src/components/**/*.stories.{ts,tsx}",
"../src/@chakra-ui/stories/*.stories.tsx",
// "../src/@chakra-ui/stories/*.stories.tsx",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why you left it commented?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! 😅

*
* Used to search CSS Variables and retrieve their values.
*
* NOTE: Function created with AI assistance
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 nice!

Comment thread src/styles/colors.stories.tsx Outdated
import { cn } from "@/lib/utils/cn"

const meta = {
title: "Design System/ShadCN Colors",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Design System/ShadCN Colors",
title: "Design System / Colors",

@TylerAPfledderer
Copy link
Copy Markdown
Contributor Author

@pettinarip should be good to go now!

@pettinarip pettinarip merged commit ec8b91f into ethereum:dev Feb 17, 2025
@TylerAPfledderer TylerAPfledderer deleted the feat/color-stories-tailwind branch February 17, 2025 15:24
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants