feat(Simulator/icons): migrate to react-icons#14873
Merged
pettinarip merged 2 commits intoFeb 12, 2025
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
force-pushed
the
feat/simulator-icons-migrate
branch
from
a3103b6 to
30d43a7
Compare
TylerAPfledderer
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
corwintines
requested review from
asanso,
djrtwo and
fredrik0x
as code owners
pettinarip
approved these changes
Feb 12, 2025
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
lgtm! thanks @TylerAPfledderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the icons in the Simulator to use
createIconBase()